| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <c7b877e66ba0d34d8558c5af8bbb620e8c0e47d9.1755096883.git.robin.murphy@arm.com>
Date: Wed, 13 Aug 2025 18:00:54 +0100
From: Robin Murphy <robin.murphy@....com>
To: peterz@...radead.org,
mingo@...hat.com,
will@...nel.org,
mark.rutland@....com,
acme@...nel.org,
namhyung@...nel.org,
alexander.shishkin@...ux.intel.com,
jolsa@...nel.org,
irogers@...gle.com,
adrian.hunter@...el.com,
kan.liang@...ux.intel.com
Cc: linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-alpha@...r.kernel.org,
linux-snps-arc@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
imx@...ts.linux.dev,
linux-csky@...r.kernel.org,
loongarch@...ts.linux.dev,
linux-mips@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org,
linux-s390@...r.kernel.org,
linux-sh@...r.kernel.org,
sparclinux@...r.kernel.org,
linux-pm@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
dmaengine@...r.kernel.org,
linux-fpga@...r.kernel.org,
amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org,
intel-xe@...ts.freedesktop.org,
coresight@...ts.linaro.org,
iommu@...ts.linux.dev,
linux-amlogic@...ts.infradead.org,
linux-cxl@...r.kernel.org,
linux-arm-msm@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: [PATCH 02/19] perf/hisilicon: Fix group validation
The group validation logic shared by the HiSilicon HNS3/PCIe drivers is
a bit off, in that given a software group leader, it will consider that
event *in place of* the actual new event being opened. At worst this
could theoretically allow an unschedulable group if the software event
config happens to look like one of the hardware siblings.
The uncore framework avoids that particular issue, but all 3 also share
the common issue of not preventing racy access to the sibling list, and
some redundant checks which can be cleaned up.
Signed-off-by: Robin Murphy <robin.murphy@....com>
---
drivers/perf/hisilicon/hisi_pcie_pmu.c | 17 ++++++-----------
drivers/perf/hisilicon/hisi_uncore_pmu.c | 23 +++++++----------------
drivers/perf/hisilicon/hns3_pmu.c | 17 ++++++-----------
3 files changed, 19 insertions(+), 38 deletions(-)
diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c
index c5394d007b61..3b0b2f7197d0 100644
--- a/drivers/perf/hisilicon/hisi_pcie_pmu.c
+++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c
@@ -338,21 +338,16 @@ static bool hisi_pcie_pmu_validate_event_group(struct perf_event *event)
int counters = 1;
int num;
- event_group[0] = leader;
- if (!is_software_event(leader)) {
- if (leader->pmu != event->pmu)
- return false;
+ if (leader == event)
+ return true;
- if (leader != event && !hisi_pcie_pmu_cmp_event(leader, event))
- event_group[counters++] = event;
- }
+ event_group[0] = event;
+ if (leader->pmu == event->pmu && !hisi_pcie_pmu_cmp_event(leader, event))
+ event_group[counters++] = leader;
for_each_sibling_event(sibling, event->group_leader) {
- if (is_software_event(sibling))
- continue;
-
if (sibling->pmu != event->pmu)
- return false;
+ continue;
for (num = 0; num < counters; num++) {
/*
diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c
index a449651f79c9..3c531b36cf25 100644
--- a/drivers/perf/hisilicon/hisi_uncore_pmu.c
+++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c
@@ -101,26 +101,17 @@ static bool hisi_validate_event_group(struct perf_event *event)
/* Include count for the event */
int counters = 1;
- if (!is_software_event(leader)) {
- /*
- * We must NOT create groups containing mixed PMUs, although
- * software events are acceptable
- */
- if (leader->pmu != event->pmu)
- return false;
+ if (leader == event)
+ return true;
- /* Increment counter for the leader */
- if (leader != event)
- counters++;
- }
+ /* Increment counter for the leader */
+ if (leader->pmu == event->pmu)
+ counters++;
for_each_sibling_event(sibling, event->group_leader) {
- if (is_software_event(sibling))
- continue;
- if (sibling->pmu != event->pmu)
- return false;
/* Increment counter for each sibling */
- counters++;
+ if (sibling->pmu == event->pmu)
+ counters++;
}
/* The group can not count events more than the counters in the HW */
diff --git a/drivers/perf/hisilicon/hns3_pmu.c b/drivers/perf/hisilicon/hns3_pmu.c
index c157f3572cae..382e469257f9 100644
--- a/drivers/perf/hisilicon/hns3_pmu.c
+++ b/drivers/perf/hisilicon/hns3_pmu.c
@@ -1058,21 +1058,16 @@ static bool hns3_pmu_validate_event_group(struct perf_event *event)
int counters = 1;
int num;
- event_group[0] = leader;
- if (!is_software_event(leader)) {
- if (leader->pmu != event->pmu)
- return false;
+ if (leader == event)
+ return true;
- if (leader != event && !hns3_pmu_cmp_event(leader, event))
- event_group[counters++] = event;
- }
+ event_group[0] = event;
+ if (leader->pmu == event->pmu && !hns3_pmu_cmp_event(leader, event))
+ event_group[counters++] = leader;
for_each_sibling_event(sibling, event->group_leader) {
- if (is_software_event(sibling))
- continue;
-
if (sibling->pmu != event->pmu)
- return false;
+ continue;
for (num = 0; num < counters; num++) {
/*
--
2.39.2.101.g768bb238c484.dirty
Powered by blists - more mailing lists