linux-kernel - Re: [PATCH] softirq: Provide a handshake for canceling tasklets via polling on PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJzT7rqwkRQrLGqo@slm.duckdns.org>
Date: Wed, 13 Aug 2025 08:05:34 -1000
From: Tejun Heo <tj@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] softirq: Provide a handshake for canceling tasklets via
 polling on PREEMPT_RT

Hello,

On Wed, Aug 13, 2025 at 08:33:11AM +0200, Sebastian Andrzej Siewior wrote:
...
> > The intention is to convert all BH users to workqueue-BH and remove BH
> > (that's what Linus wants and why workqueue-BH came to be), so the APIs
> > should be able to match up, I'm afraid. There were some attempts at pushing
> > the conversion but we've only made minimal progress. If you're looking at BH
> > users anyway and feel like it, please feel free to convert them.
> 
> I understand this but I am talking about legacy users:
> 
> | drivers/atm/eni.c:      tasklet_disable_in_atomic(&ENI_DEV(vcc->dev)->task);
> | drivers/net/wireless/ath/ath9k/beacon.c:        tasklet_disable_in_atomic(&sc->bcon_tasklet);
> | drivers/pci/controller/pci-hyperv.c:    tasklet_disable_in_atomic(&channel->callback_event);
> 
> This is what is left. (There is also i915 but this is "special").
> So we are talking about establishing an API and behaviour for those here
> after we painfully managed converting everyone else away:

Right, given how early in conversion, we can definitely leave this as
something to think about later. I have no objection to leave it be for now.

Thanks.

-- 
tejun