linux-kernel - [PATCH V1] of: dynamic: Fix memleak when of_pci_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250813182849.3229140-1-lizhi.hou@amd.com>
Date: Wed, 13 Aug 2025 11:28:49 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: <robh@...nel.org>, <lpieralisi@...nel.org>
CC: Lizhi Hou <lizhi.hou@....com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH V1] of: dynamic: Fix memleak when of_pci_add_properties failed

When of_pci_add_properties failed, of_changeset_destroy is called to free
the changeset. And of_changeset_destroy puts device tree node in each entry
but does not free property in the entry. This leads to memory leak in the
failure case.

In of_changeset_add_prop_helper, add the property to the device tree node
deadprops list. Thus, the property will also be freed along with device
tree node.

Fixes: b544fc2b8606 ("of: dynamic: Add interfaces for creating device node dynamically")
Reported-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
Closes: https://lore.kernel.org/all/aJms+YT8TnpzpCY8@lpieralisi/
Signed-off-by: Lizhi Hou <lizhi.hou@....com>
---
 drivers/of/dynamic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 0aba760f7577..dd30b7d8b5e4 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -938,6 +938,9 @@ static int of_changeset_add_prop_helper(struct of_changeset *ocs,
 	if (ret)
 		__of_prop_free(new_pp);
 
+	new_pp->next = np->deadprops;
+	np->deadprops = new_pp;
+
 	return ret;
 }
 
-- 
2.34.1