linux-kernel - Re: [PATCH v2] x86/CPU/AMD: Ignore invalid reset reason value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250813193224.GA52005@yaz-khff2.amd.com>
Date: Wed, 13 Aug 2025 15:32:24 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: x86@...nel.org
Cc: linux-kernel@...r.kernel.org, Libing He <libhe@...hat.com>,
	Mario Limonciello <mario.limonciello@....com>,
	David Arcari <darcari@...hat.com>
Subject: Re: [PATCH v2] x86/CPU/AMD: Ignore invalid reset reason value

On Wed, Jul 23, 2025 at 08:07:52PM +0000, Yazen Ghannam wrote:
> The reset reason value may be "all bits set", e.g. 0xFFFFFFFF. This is a
> commonly used error response from hardware. This may occur due to a real
> hardware issue or when running in a VM.
> 
> The user will see all reset reasons reported in this case.
> 
> Return early if running in a VM as this register is not emulated.
> 
> Check for an error response value and return early to avoid decoding
> invalid data.
> 
> Also, adjust the data variable type to match the hardware register size.
> 
> Fixes: ab8131028710 ("x86/CPU/AMD: Print the reason for the last reset")
> Reported-by: Libing He <libhe@...hat.com>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> Cc: David Arcari <darcari@...hat.com>
> Cc: stable@...r.kernel.org
> ---

Hi all,

Any more feedback on this?

Thanks,
Yazen