[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <623c0ef4-98c0-410c-abf3-fa9563f52688@baylibre.com>
Date: Wed, 13 Aug 2025 16:11:59 -0500
From: David Lechner <dlechner@...libre.com>
To: Ben Collins <bcollins@...ter.com>, Jonathan Cameron <jic23@...nel.org>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Andrew Hepp <andrew.hepp@...pp.dev>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: iio: mcp9600: Add compatible for
microchip,mcp9601
On 8/13/25 10:15 AM, Ben Collins wrote:
> MCP9601 is a superset of MCP9600 and is supported by the driver.
>
> Signed-off-by: Ben Collins <bcollins@...ter.com>
> ---
Please include a cover letter with a changelog in v3.
> .../bindings/iio/temperature/microchip,mcp9600.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> index d2cafa38a5442..d8af0912ce886 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml
> @@ -4,7 +4,7 @@
> $id: http://devicetree.org/schemas/iio/temperature/microchip,mcp9600.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Microchip MCP9600 thermocouple EMF converter
> +title: Microchip MCP9600 and similar thermocouple EMF converters
>
> maintainers:
> - Andrew Hepp <andrew.hepp@...pp.dev>
> @@ -14,7 +14,9 @@ description:
>
> properties:
> compatible:
> - const: microchip,mcp9600
> + enum:
> + - microchip,mcp9600
> + - microchip,mcp9601
>
It sounds like it would be useful to have a fallback in this case:
properties:
compatible:
oneOf:
- const: microchip,mcp9600
- items:
- - microchip,mcp9600
- microchip,mcp9600
> reg:
> maxItems: 1
Usage would then be:
compatible = "microchip,mcp9601", "microchip,mcp9600";
Powered by blists - more mailing lists