linux-kernel - Re: [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxU2N8kHd8Sm1gLECekYzuW-APyBNxOi8K2k8yO1qWTqbsPeQ@mail.gmail.com>
Date: Wed, 13 Aug 2025 16:07:34 -0700
From: Rosen Penev <rosenp@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-wireless@...r.kernel.org, Toke Høiland-Jørgensen <toke@...e.dk>, 
	Johannes Berg <johannes@...solutions.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	"open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

On Wed, Aug 13, 2025 at 1:18 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 12/08/2025 21:23, Rosen Penev wrote:
> > A port of the prior platform code to use OF.
> >
> > v2: use reg instead of led-sources
>
> Where? Really, where? There is no reg in the binding at all. There is
> led-sources, though. Also many other things got changed, the binding is
> completely different and nothing in changelog explains that.
Yeah. The initial was copy/paste from mt76 driver. But then on review
I was told to change led-sources to reg and did not completely change
that in the patchset.
>
> Best regards,
> Krzysztof