linux-kernel - Re: [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e109905-347d-4830-aea6-a93d88252481@baylibre.com>
Date: Wed, 13 Aug 2025 18:12:26 -0500
From: David Lechner <dlechner@...libre.com>
To: Andrew Davis <afd@...com>, Jonathan Cameron <jic23@...nel.org>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get_enable()
 helper

On 8/13/25 5:58 PM, Andrew Davis wrote:
> This takes care of both getting and enabling the regulator in one
> function, it also handles the devm action, so remove that. Also
> do not disable the regulator on suspend, this will be handled for

I didn't know that this worked automatically. What is the mechanism
that makes it work? I've seen lots of drivers doing the disable/
enable in suspend/resume, so I just always assumed that was how one
is supposed to do it.

> us. We now do not need to track the regulator at all, so drop it
> from the device struct.
> 
> Signed-off-by: Andrew Davis <afd@...com>