linux-kernel - Re: [RESEND PATCH net-next v3] net/core: fix wrong return value in __splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250813162709.6d876ba4@kernel.org>
Date: Wed, 13 Aug 2025 16:27:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Pengtao He <hept.hept.hept@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>, Mina Almasry
 <almasrymina@...gle.com>, Jason Xing <kerneljasonxing@...il.com>, Michal
 Luczaj <mhal@...x.co>, Eric Biggers <ebiggers@...gle.com>, Alexander
 Lobakin <aleksander.lobakin@...el.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH net-next v3] net/core: fix wrong return value in
 __splice_segment

On Tue, 12 Aug 2025 07:28:01 +0800 Pengtao He wrote:
> Return true immediately when the last segment is processed,
> avoid to walking once more in the frags loop.

Please explain this change more clearly in the commit message.

Took me a minute to realize you're concerned about the caller
behavior not __splice_segment() itself.
-- 
pw-bot: cr