linux-kernel - Re: [PATCH 2/6] kbuild: uapi: only update hdrtest output on success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250813072751-ed791f27-41c5-4be7-9a57-cb79301da763@linutronix.de>
Date: Wed, 13 Aug 2025 07:29:17 +0200
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>, 
	Nicolas Schier <nicolas.schier@...ux.dev>, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] kbuild: uapi: only update hdrtest output on success

On Wed, Aug 13, 2025 at 09:29:31AM +0900, Masahiro Yamada wrote:
> On Tue, Aug 12, 2025 at 2:33 PM Thomas Weißschuh
> <thomas.weissschuh@...utronix.de> wrote:
> >
> > If a header test fails, the output should not be updated.
> > Otherwise the next make invocation will not rerun the test.
> >
> > Also headers_check.pl should only run if the syntax check invocation
> > before succeeded.
> >
> > Add explicit sequencening.
> 
> Did you test this?

At least I thought so.

> See scripts/Kbuild.include line 153
> 
> The macro 'cmd' has "set -e".
> 
> Any single error in a series of commands
> bails out.

Indeed, this patch is pointless. I will drop it.

Thanks!

> >
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> > ---
> >  usr/include/Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/usr/include/Makefile b/usr/include/Makefile
> > index c7f164952b33acf6c7b8eb7ce91cd192bfc39ad2..6868d183f36d532cd3d4023b936c67b8a58a9ba5 100644
> > --- a/usr/include/Makefile
> > +++ b/usr/include/Makefile
> > @@ -81,8 +81,8 @@ always-y := $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '*.h' 2>/
> >  quiet_cmd_hdrtest = HDRTEST $<
> >        cmd_hdrtest = \
> >                 $(CC) $(c_flags) -fsyntax-only -x c /dev/null \
> > -                       $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \
> > -               $(PERL) $(src)/headers_check.pl $(obj) $<; \
> > +                       $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<) && \
> > +               $(PERL) $(src)/headers_check.pl $(obj) $< && \
> >                 touch $@
> >
> >  $(obj)/%.hdrtest: $(obj)/%.h $(src)/headers_check.pl FORCE