linux-kernel - Re: [PATCH v3 1/5] panic: clean up code for console replay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJvfySHZ2h8Tecat@U-2FWC9VHC-2323.local>
Date: Wed, 13 Aug 2025 08:43:53 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Askar Safin <safinaskar@...omail.com>, akpm <akpm@...ux-foundation.org>,
	corbet <corbet@....net>, "john.ogness" <john.ogness@...utronix.de>,
	"lance.yang" <lance.yang@...ux.dev>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	paulmck <paulmck@...nel.org>, rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v3 1/5] panic: clean up code for console replay

On Tue, Aug 12, 2025 at 01:59:32PM +0200, Petr Mladek wrote:
> On Tue 2025-07-15 11:27:54, Feng Tang wrote:
> > On Tue, Jul 15, 2025 at 06:48:47AM +0400, Askar Safin wrote:
> > > 
> > >  ---- On Tue, 15 Jul 2025 05:34:39 +0400  Feng Tang <feng.tang@...ux.alibaba.com> wrote --- 
> > >  > I see. How about changing the patch to: 
> > >  > 
> > >  > -            bit 5: print all printk messages in buffer
> > >  > +            bit 5: replay all kernel messages on consoles at the end of panic
> > > 
> > > Yes, I agree!
> > 
> > Hi Andrew,
> > 
> > Could you help to squash below patch to 1/5 patch "panic: clean up code
> > for console replay" in the nonmmu-unstable branch? Thanks!
> > 
> > - Feng
> > 
> > ---
> >  Documentation/admin-guide/kernel-parameters.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index f34de9978a91..a84d3f7f5bbf 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -4533,7 +4533,7 @@
> >  			bit 2: print timer info
> >  			bit 3: print locks info if CONFIG_LOCKDEP is on
> >  			bit 4: print ftrace buffer
> > -			bit 5: replay all messages on consoles at the end of panic
> > +			bit 5: replay all kernel messages on consoles at the end of panic
> >  			bit 6: print all CPUs backtrace (if available in the arch)
> >  			bit 7: print only tasks in uninterruptible (blocked) state
> >  			*Be aware* that this option may print a _lot_ of lines,
> 
> Yes, this looks better.
> 
> It sees that this change is missing in the mainline.
> Fang, could you please send it as a followup fix, please?

Sure. Will do.

Thanks,
Feng