linux-kernel - Re: [PATCH 2/6] kbuild: uapi: only update hdrtest output on success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJwmtfA4U1jOXljP@levanger>
Date: Wed, 13 Aug 2025 07:46:29 +0200
From: Nicolas Schier <nsc@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
	Nathan Chancellor <nathan@...nel.org>, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] kbuild: uapi: only update hdrtest output on success

On Wed, Aug 13, 2025 at 09:29:31AM +0900, Masahiro Yamada wrote:
> On Tue, Aug 12, 2025 at 2:33 PM Thomas Weißschuh
> <thomas.weissschuh@...utronix.de> wrote:
> >
> > If a header test fails, the output should not be updated.
> > Otherwise the next make invocation will not rerun the test.
> >
> > Also headers_check.pl should only run if the syntax check invocation
> > before succeeded.
> >
> > Add explicit sequencening.
> 
> Did you test this?
> 
> See scripts/Kbuild.include line 153
> 
> The macro 'cmd' has "set -e".
> 
> Any single error in a series of commands
> bails out.

Ah thanks!  Yes, for me it works correct w/o the patch.

I was struggling with this: If I apply this patch, make no more forwards
the error code if headers_check.pl exits with error.

It's actually a bit funny:

W/o this patch, we have a command sequence like:

    set -e; date ; false ; true; date

which bails out at false at stops processing subsequent commands.
Replacing the semicolons by '&&'

    set -e; date && false && true; date

will prevent 'true' to be run, but the trailing 'date' will still be
executed.

Kind regards,
Nicolas