linux-kernel - Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on sa8775p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac83c453-c24d-4c4d-83bc-9ed13f2f9d1e@kernel.org>
Date: Wed, 13 Aug 2025 08:02:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Odelu Kukatla <odelu.kukatla@....qualcomm.com>,
 Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Mike Tipton <mike.tipton@....qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to
 enable QoS on sa8775p

On 13/08/2025 07:55, Odelu Kukatla wrote:
> 
> 
> On 8/12/2025 3:47 PM, Krzysztof Kozlowski wrote:
>> On 08/08/2025 16:02, Odelu Kukatla wrote:
>>> Add reg and clocks properties to enable the clocks required
>>> for accessing QoS configuration.
>>
>>
>> Nothing here explains why EXISTING hardware is being changed. I also
>> remember big discussions and big confusing patches regarding sa8775p
>> (its rename, dropping/changing all providers), and this patch feels like
>> pieces of it without proper justification.
>>
> Thanks for the review.
> I have added description in cover letter, i will add here as well in next revision.> And this is hidden ABI break, no justification, no mentioning either.
>> Again we are discussing basics of ABI breaking patches?
>>
> If you are talking ABI break if we load old DT which may lead to crash, we have .qos_requires_clocks flag which takes care of skipping QoS if required clocks are not enabled.we have addressed this issue through https://lore.kernel.org/all/20240704125515.22194-1-quic_okukatla@quicinc.com/ 

Format your emails correctly, it's difficult to read.

Your binding did not require reg and clocks. Now it requires reg and
clocks. This is called ABI break.

Please follow Qualcomm extensive upstreaming guide, it explains this,
doesn't it? Or follow writing bindings...

Best regards,
Krzysztof