linux-kernel - Re: [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <074fcd4c-0da8-42c4-a567-64fa7e173894@kernel.org>
Date: Wed, 13 Aug 2025 08:14:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sven Peter <sven@...nel.org>, Janne Grunau <j@...nau.net>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa <neal@...pa.dev>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rtc@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add Apple SMC RTC

On 12/08/2025 20:25, Sven Peter wrote:
> +maintainers:
> +  - Sven Peter <sven@...nel.org>
> +
> +properties:
> +  compatible:
> +    const: apple,smc-rtc
> +

No resources except nvmem? This should be folded into the parent. Don't
create device node to instantiate drivers.

> +  nvmem-cells:
> +    items:
> +      - description: 48bit RTC offset, specified in 32768 (2^15) Hz clock ticks
> +
> +  nvmem-cell-names:
> +    items:
> +      - const: rtc_offset
> +
> +required:
> +  - compatible
> +  - nvmem-cells
> +  - nvmem-cell-names
> +
> +additionalProperties: false

Missing example. If this is part of other device (like MFD), then the
one there should be extended here.

> 


Best regards,
Krzysztof