linux-kernel - Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d43dac3e-122d-4c16-9c1e-760eac91b8da@embeddedor.com>
Date: Wed, 13 Aug 2025 14:12:30 +0900
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Alex Deucher <alexdeucher@...il.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Kenneth Feng <kenneth.feng@....com>, Alex Deucher
 <alexander.deucher@....com>, Christian König
 <christian.koenig@....com>, Xinhui Pan <Xinhui.Pan@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] drm/amd/pm: Avoid multiple
 -Wflex-array-member-not-at-end warnings

Hi!

On 22/04/25 23:58, Gustavo A. R. Silva wrote:
> 
> 
> On 16/04/25 09:04, Alex Deucher wrote:
>> Can you resend, I can't seem to find the original emails.
>> Additionally, all of the NISLANDS structures are unused in amdgpu, so
>> those could be removed.

I'm taking a look at this, and it seems that those NISLANDS structs are actually
needed in amdgpu code. For instance, `struct si_power_info` contains a member
of the type of `struct ni_power_info`, and this latter struct contains a
member of the type of `NISLANDS_SMC_STATETABLE`, thus `NISLANDS_SMC_SWSTATE`
and `NISLANDS_SMC_HW_PERFORMANCE_LEVEL` are needed, and so on.

So, it seems that all those structs should stay. What do you think?

Thanks!
-Gustavo