linux-kernel - Re: [PATCH 1/3] spi: dt-bindings: add doc for Amlogic A113L2 SFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cc336bc-f071-41d2-b59a-af0df23af00b@kernel.org>
Date: Wed, 13 Aug 2025 09:36:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xianwei Zhao <xianwei.zhao@...ogic.com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Liang Yang <liang.yang@...ogic.com>,
 Feng Chen <feng.chen@...ogic.com>, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 1/3] spi: dt-bindings: add doc for Amlogic A113L2 SFC

On 13/08/2025 08:13, Xianwei Zhao wrote:
>>> +allOf:
>>> +  - $ref: /schemas/spi/spi-controller.yaml#
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: amlogic,a4-spifc
>>> +
>>> +  reg:
>>> +    items:
>>> +      - description: core registers
>>> +      - description: parent clk control registers
>>
>> Why are you poking to parent node or to clock registers? This looks like
>> mixing up device address spaces.
>>
> 
> The SPIFC bus clock multiplexes EMMC modules, so the corresponding 
> frequency division register is also in EMMC module. The SPIFC and the 
> EMMC modules cannot be used simultaneously.

Then obviously you cannot put here EMMC or parent registers.

It looks really like you miss proper hardware representation.

> 
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: core
>>> +      - const: pclk
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: clock gate
>>
>> Are you sure this is separate clock input to this device?
>>
> 
> This clock is used by the APB interface to access the SPIFC registers.

So APB clock?



Best regards,
Krzysztof