linux-kernel - Re: [PATCH] rust: cpumask: Mark CpumaskVar as transparent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLgg6eFYZ906GPFev_nha0axsUR71yC+En4X_fMjSn85UiA@mail.gmail.com>
Date: Wed, 13 Aug 2025 09:40:42 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Baptiste Lepers <baptiste.lepers@...il.com>
Cc: stable@...r.kernel.org, Viresh Kumar <viresh.kumar@...aro.org>, 
	Yury Norov <yury.norov@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: cpumask: Mark CpumaskVar as transparent

On Tue, Aug 12, 2025 at 4:42 PM Baptiste Lepers
<baptiste.lepers@...il.com> wrote:
>
> Unsafe code in CpumaskVar's methods assumes that the type has the same
> layout as `bindings::cpumask_var_t`. This is not guaranteed by
> the default struct representation in Rust, but requires specifying the
> `transparent` representation.
>
> Fixes: 8961b8cb3099a ("rust: cpumask: Add initial abstractions")
> Cc: stable@...r.kernel.org
> Signed-off-by: Baptiste Lepers <baptiste.lepers@...il.com>

Only during CONFIG_CPUMASK_OFFSTACK=n, but yes.

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>