linux-kernel - Re: [PATCH v8 4/4] can: m_can: Support pinctrl wakeup state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250813-apricot-cicada-of-apotheosis-e8d5fa-mkl@pengutronix.de>
Date: Wed, 13 Aug 2025 09:54:47 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Markus Schneider-Pargmann <msp@...libre.com>
Cc: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Vishal Mahaveer <vishalm@...com>, 
	Kevin Hilman <khilman@...libre.com>, Dhruva Gole <d-gole@...com>, 
	Sebin Francis <sebin.francis@...com>, Kendall Willis <k-willis@...com>, Akashdeep Kaur <a-kaur@...com>, 
	Simon Horman <horms@...nel.org>, Vincent MAILHOL <mailhol.vincent@...adoo.fr>, 
	linux-can@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 4/4] can: m_can: Support pinctrl wakeup state

On 13.08.2025 09:44:35, Marc Kleine-Budde wrote:
> On 12.08.2025 11:10:25, Markus Schneider-Pargmann wrote:
> > am62 requires a wakeup flag being set in pinctrl when mcan pins acts as
> > a wakeup source. Add support to select the wakeup state if WOL is
> > enabled.
> 
> The driver makes already use of pinctrl_pm_select_default_state(dev),
> does it make sense to use it here, too?

Every suspend/resume cycle will overwrite the pinctrl setting with the
default one.

| int m_can_class_resume(struct device *dev)
| {
| [...]
| 	pinctrl_pm_select_default_state(dev);

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)