linux-kernel - Re: [PATCH net-next] nfc: pn533: Delete an unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d7c789-0872-4d6b-9ef2-db3543f1d295@kernel.org>
Date: Wed, 13 Aug 2025 10:13:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Lars Poeschel <poeschel@...onage.de>
Cc: Paolo Abeni <pabeni@...hat.com>, Aleksandr Mishin <amishin@...rgos.ru>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] nfc: pn533: Delete an unnecessary check

On 13/08/2025 07:51, Dan Carpenter wrote:
> The "rc" variable is set like this:
> 
> 	if (IS_ERR(resp)) {
> 		rc = PTR_ERR(resp);
> 
> We know that "rc" is negative so there is no need to check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/nfc/pn533/pn533.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof