linux-kernel - Re: [PATCH 1/4] dt-bindings: iio: adc: ad7768-1: add new supported parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3cf9b97-3883-4ebb-a2ed-0033adebda87@kernel.org>
Date: Wed, 13 Aug 2025 10:27:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonathan Santos <Jonathan.Santos@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Michael.Hennerich@...log.com, jic23@...nel.org, dlechner@...libre.com,
 nuno.sa@...log.com, andy@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, jonath4nns@...il.com
Subject: Re: [PATCH 1/4] dt-bindings: iio: adc: ad7768-1: add new supported
 parts

On 13/08/2025 04:48, Jonathan Santos wrote:
> Add compatibles for supported parts in the ad7768-1 family:
> 	ADAQ7767-1, ADAQ7768-1 and ADAQ7769-1
> 
> Add property and checks for AFF gain, supported by ADAQ7767-1
> and ADAQ7769-1 parts:
> 	adi,aaf-gain
> 
> Signed-off-by: Jonathan Santos <Jonathan.Santos@...log.com>
> ---
>  .../bindings/iio/adc/adi,ad7768-1.yaml        | 48 +++++++++++++++++--
>  1 file changed, 44 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> index c06d0fc791d3..568a85e0d052 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> @@ -4,18 +4,26 @@
>  $id: http://devicetree.org/schemas/iio/adc/adi,ad7768-1.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices AD7768-1 ADC device driver
> +title: Analog Devices AD7768-1 ADC family device driver

If doing this, drop device driver. It should not be here in the first place.

>  
>  maintainers:
>    - Michael Hennerich <michael.hennerich@...log.com>
>  
>  description: |
> -  Datasheet at:
> -    https://www.analog.com/media/en/technical-documentation/data-sheets/ad7768-1.pdf
> +  Analog Devices AD7768-1 24-Bit Single Channel Low Power sigma-delta ADC family
> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad7768-1.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/adaq7767-1.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/adaq7768-1.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/adaq7769-1.pdf
>  
>  properties:
>    compatible:
> -    const: adi,ad7768-1
> +    enum:
> +      - adi,ad7768-1
> +      - adi,adaq7767-1
> +      - adi,adaq7768-1
> +      - adi,adaq7769-1
>  
>    reg:
>      maxItems: 1
> @@ -58,6 +66,23 @@ properties:
>      description:
>        ADC reference voltage supply
>  
> +  adi,aaf-gain:
> +    description: |
> +      Specifies the gain of the Analog Anti-Aliasing Filter (AAF) applied to the
> +      ADC input, measured in milli-units. The AAF provides additional signal

What is milli unit? Isn't gain in dB, so maybe you want mB? Quite
unpopular to see mB, but we cannot use 1/100 of dB, so I could
understand it.

> +      rejection within the frequency range of fs ± f3dB, where fs is the sampling
> +      frequency, and f3dB is the -3dB cutoff frequency. The specific values of
> +      fs and f3dB, as well as the rejection intensity, depend on the digital
> +      filter configuration.
Best regards,
Krzysztof