linux-kernel - Re: [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove duplicated counter rx_long_byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250813085428.89006-1-enjuk@amazon.com>
Date: Wed, 13 Aug 2025 17:54:23 +0900
From: Kohei Enju <enjuk@...zon.com>
To: <pmenzel@...gen.mpg.de>
CC: <andrew+netdev@...n.ch>, <anthony.l.nguyen@...el.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <enjuk@...zon.com>,
	<intel-wired-lan@...ts.osuosl.org>, <kohei.enju@...il.com>,
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH v1 iwl-next 2/2] igbvf: remove
 duplicated counter rx_long_byte_count from ethtool statistics

On Wed, 13 Aug 2025 10:20:33 +0200, Paul Menzel wrote:

> Dear Kohei,
> 
> 
> Thank you for your patch.
> 
> Am 13.08.25 um 09:50 schrieb Kohei Enju:
> > rx_long_byte_count shows the value of the GORC (Good Octets Received
> > Count) register. However, the register value is already shown as
> > rx_bytes and they always show the same value.
> > 
> > Remove rx_long_byte_count as the Intel ethernet driver e1000e did in
> > commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter").
> > 
> > Tested on Intel Corporation I350 Gigabit Network Connection.
> > 
> > Tested-by: Kohei Enju <enjuk@...zon.com>
> > Signed-off-by: Kohei Enju <enjuk@...zon.com>
> > ---
> >   drivers/net/ethernet/intel/igbvf/ethtool.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c
> > index c6defc495f13..9c08ebfad804 100644
> > --- a/drivers/net/ethernet/intel/igbvf/ethtool.c
> > +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c
> > @@ -36,7 +36,6 @@ static const struct igbvf_stats igbvf_gstrings_stats[] = {
> >   	{ "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) },
> >   	{ "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) },
> >   	{ "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base) },
> > -	{ "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc) },
> >   	{ "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base) },
> >   	{ "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base) },
> >   	{ "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) },
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Thank you for reviewing!

> 
> Kind regards,
> 
> Paul
> 
> 
> PS: Should you resend, *redundant* instead of *duplicated* might better 
> describe the removed counter.

Sure, I resend this patch as v2 with the changes:
  - s/duplicated/redundant/
  - Remove Tested-by: tag
  - Add Reviewed-by: tag

Thanks for the feedback.