| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <175507897155.560048.8971835015591511326@ping.linuxembedded.co.uk>
Date: Wed, 13 Aug 2025 10:56:11 +0100
From: Kieran Bingham <kieran.bingham@...asonboard.com>
To: Jai Luthra <jai.luthra@...asonboard.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Jai Luthra <jai.luthra@...asonboard.com>
Subject: Re: [PATCH 6/6] media: imx335: Support 2x2 binning
Quoting Jai Luthra (2025-08-13 08:20:37)
> Introduce 2x2 binning mode (1312x972@...ps). Since there are multiple
> modes now, use v4l2_find_nearest_size() to select the appropriate mode
> in .set_fmt().
>
> For 2x2 binning the minimum shutter value supported is 17 instead of 9.
> This effects the maximum allowed exposure time, and if not enforced then
> the sensor produces very dark frames when the minimum shutter limit is
> violated.
>
> Lastly, update the crop size reported to the userspace. When trying 2x2
> binning with the datasheet suggested pixel array size (i.e. 2592 / 2 =>
> 1296), on some platforms (Raspberry Pi 5) artefacts are introduced on
It was visible on i.MX8MP too. I look forward to testing this update on
my platform!
> the right edge of the output image. Instead, using a higher width of
> 1312 works fine on all platforms.
>
> Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>
> ---
> drivers/media/i2c/imx335.c | 274 +++++++++++++++++++++++++++++++++++----------
> 1 file changed, 217 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index df1535927f481de3a0d043ac9be24b9336ea8f7f..24d26bc6260bf60ca73df81fe398121ac9371b42 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -35,6 +35,7 @@
>
> /* Lines per frame */
> #define IMX335_REG_VMAX CCI_REG24_LE(0x3030)
> +#define IMX335_REG_HMAX CCI_REG16_LE(0x3034)
>
> #define IMX335_REG_OPB_SIZE_V CCI_REG8(0x304c)
> #define IMX335_REG_ADBIT CCI_REG8(0x3050)
> @@ -42,10 +43,13 @@
>
> #define IMX335_REG_SHUTTER CCI_REG24_LE(0x3058)
> #define IMX335_EXPOSURE_MIN 1
> -#define IMX335_EXPOSURE_OFFSET 9
> +#define IMX335_SHUTTER_MIN 9
> +#define IMX335_SHUTTER_MIN_BINNED 17
> #define IMX335_EXPOSURE_STEP 1
> #define IMX335_EXPOSURE_DEFAULT 0x0648
>
> +#define IMX335_REG_AREA2_WIDTH_1 CCI_REG16_LE(0x3072)
> +
Ohh what's the distinction between Area2 and Area3 ? (I should probably
jsut open the datasheet to answer that myself ...)
> #define IMX335_REG_AREA3_ST_ADR_1 CCI_REG16_LE(0x3074)
> #define IMX335_REG_AREA3_WIDTH_1 CCI_REG16_LE(0x3076)
>
> @@ -126,9 +130,9 @@
> /* IMX335 native and active pixel array size. */
> #define IMX335_NATIVE_WIDTH 2696U
> #define IMX335_NATIVE_HEIGHT 2044U
> -#define IMX335_PIXEL_ARRAY_LEFT 52U
> +#define IMX335_PIXEL_ARRAY_LEFT 36U
> #define IMX335_PIXEL_ARRAY_TOP 50U
> -#define IMX335_PIXEL_ARRAY_WIDTH 2592U
> +#define IMX335_PIXEL_ARRAY_WIDTH 2624U
> #define IMX335_PIXEL_ARRAY_HEIGHT 1944U
Should these changes have been in the earlier "Update the native pixel
array width" patch?
>
> /**
> @@ -147,8 +151,14 @@ static const char * const imx335_supply_name[] = {
> "dvdd", /* Digital Core (1.2V) supply */
> };
>
> +enum imx335_scan_mode {
> + IMX335_ALL_PIXEL,
> + IMX335_2_2_BINNING,
> +};
> +
> /**
> * struct imx335_mode - imx335 sensor mode structure
> + * @scan_mode: Configuration scan mode (All pixel / 2x2Binning)
> * @width: Frame width
> * @height: Frame height
> * @code: Format code
> @@ -162,6 +172,7 @@ static const char * const imx335_supply_name[] = {
> * @vflip_inverted: Register list vflip (inverted readout)
> */
> struct imx335_mode {
> + enum imx335_scan_mode scan_mode;
> u32 width;
> u32 height;
> u32 code;
> @@ -263,12 +274,33 @@ static const struct cci_reg_sequence mode_2592x1944_regs[] = {
> { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY },
> { IMX335_REG_MASTER_MODE, 0x00 },
> { IMX335_REG_WINMODE, 0x04 },
> + { IMX335_REG_HMAX, 550 },
Is this more related to the media: imx335: Update HBLANK range on mode
change patch too?
Or perhaps distinct on it's own? If this isn't the default value perhaps
it needs a separate commit message explaining it.
If HMAX is only 550 - is it in some clock specific unit ? But I'm not
too worried about that until we want variable HBLANK.
> { IMX335_REG_HTRIMMING_START, 48 },
> { IMX335_REG_HNUM, 2592 },
> { IMX335_REG_Y_OUT_SIZE, 1944 },
> + { IMX335_REG_AREA2_WIDTH_1, 40 },
> { IMX335_REG_AREA3_WIDTH_1, 3928 },
> { IMX335_REG_OPB_SIZE_V, 0 },
> { IMX335_REG_XVS_XHS_DRV, 0x00 },
> +};
> +
> +static const struct cci_reg_sequence mode_1312x972_regs[] = {
> + { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY },
> + { IMX335_REG_MASTER_MODE, 0x00 },
> + { IMX335_REG_WINMODE, 0x01 },
> + { IMX335_REG_HMAX, 275 },
> + { IMX335_REG_HTRIMMING_START, 48 },
> + { IMX335_REG_HNUM, 2600 },
> + { IMX335_REG_Y_OUT_SIZE, 972 },
> + { IMX335_REG_AREA2_WIDTH_1, 48 },
> + { IMX335_REG_AREA3_WIDTH_1, 3936 },
> + { IMX335_REG_OPB_SIZE_V, 0 },
> + { IMX335_REG_XVS_XHS_DRV, 0x00 },
> + { CCI_REG8(0x3300), 1 }, /* TCYCLE */
> + { CCI_REG8(0x3199), 0x30 }, /* HADD/VADD */
> +};
> +
> +static const struct cci_reg_sequence imx335_common_regs[] = {
> { CCI_REG8(0x3288), 0x21 },
> { CCI_REG8(0x328a), 0x02 },
> { CCI_REG8(0x3414), 0x05 },
> @@ -359,16 +391,72 @@ static const struct cci_reg_sequence mode_2592x1944_vflip_inverted[] = {
> { CCI_REG16_LE(0x3116), 0x002 },
> };
>
> -static const struct cci_reg_sequence raw10_framefmt_regs[] = {
> - { IMX335_REG_ADBIT, 0x00 },
> - { IMX335_REG_MDBIT, 0x00 },
> - { IMX335_REG_ADBIT1, 0x1ff },
> +static const struct cci_reg_sequence mode_1312x972_vflip_normal[] = {
> + { IMX335_REG_AREA3_ST_ADR_1, 176 },
> +
> + /* Undocumented */
> + { CCI_REG8(0x3078), 0x04 },
> + { CCI_REG8(0x3079), 0xfd },
> + { CCI_REG8(0x307a), 0x04 },
> + { CCI_REG8(0x307b), 0xfe },
> + { CCI_REG8(0x307c), 0x04 },
> + { CCI_REG8(0x307d), 0xfb },
> + { CCI_REG8(0x307e), 0x04 },
> + { CCI_REG8(0x307f), 0x02 },
That set are common to both modes.
> + { CCI_REG8(0x3080), 0x04, },
> + { CCI_REG8(0x3081), 0xfd, },
> + { CCI_REG8(0x3082), 0x04, },
> + { CCI_REG8(0x3083), 0xfe, },
> + { CCI_REG8(0x3084), 0x04, },
> + { CCI_REG8(0x3085), 0xfb, },
> + { CCI_REG8(0x3086), 0x04, },
> + { CCI_REG8(0x3087), 0x02, },
These are a suspicious mix of switching between 0xfc,0xfd,
0x02,0x03,0x04,0x05... but I haven't spent enough time to analyse what
the pattern or underlying meaning could be yet.
> + { CCI_REG8(0x30a4), 0x77, },
> + { CCI_REG8(0x30a8), 0x20, },
> + { CCI_REG8(0x30a9), 0x00, },
> + { CCI_REG8(0x30ac), 0x08, },
> + { CCI_REG8(0x30ad), 0x08, },
> + { CCI_REG8(0x30b0), 0x20, },
> + { CCI_REG8(0x30b1), 0x00, },
> + { CCI_REG8(0x30b4), 0x10, },
> + { CCI_REG8(0x30b5), 0x10, },
It's a lot of churn for a flipped scan out ... But codifying just the
differences without knowing the underlying meaning of those registers
probably isn't worth the effort at the moment.
So I think keeping these tables is unfortunately the sanest thing to do
for now.
> + { CCI_REG16_LE(0x30b6), 0x00 },
> + { CCI_REG16_LE(0x3112), 0x10 },
> + { CCI_REG16_LE(0x3116), 0x10 },
> };
>
> -static const struct cci_reg_sequence raw12_framefmt_regs[] = {
> - { IMX335_REG_ADBIT, 0x01 },
> - { IMX335_REG_MDBIT, 0x01 },
> - { IMX335_REG_ADBIT1, 0x47 },
> +static const struct cci_reg_sequence mode_1312x972_vflip_inverted[] = {
> + { IMX335_REG_AREA3_ST_ADR_1, 4112 },
> +
> + /* Undocumented */
> + { CCI_REG8(0x3078), 0x04 },
> + { CCI_REG8(0x3079), 0xfd },
> + { CCI_REG8(0x307a), 0x04 },
> + { CCI_REG8(0x307b), 0xfe },
> + { CCI_REG8(0x307c), 0x04 },
> + { CCI_REG8(0x307d), 0xfb },
> + { CCI_REG8(0x307e), 0x04 },
> + { CCI_REG8(0x307f), 0x02 },
> + { CCI_REG8(0x3080), 0xfc, },
> + { CCI_REG8(0x3081), 0x05, },
> + { CCI_REG8(0x3082), 0xfc, },
> + { CCI_REG8(0x3083), 0x02, },
> + { CCI_REG8(0x3084), 0xfc, },
> + { CCI_REG8(0x3085), 0x03, },
> + { CCI_REG8(0x3086), 0xfc, },
> + { CCI_REG8(0x3087), 0xfe, },
> + { CCI_REG8(0x30a4), 0x77, },
> + { CCI_REG8(0x30a8), 0x20, },
> + { CCI_REG8(0x30a9), 0x00, },
> + { CCI_REG8(0x30ac), 0x08, },
> + { CCI_REG8(0x30ad), 0x78, },
> + { CCI_REG8(0x30b0), 0x20, },
> + { CCI_REG8(0x30b1), 0x00, },
> + { CCI_REG8(0x30b4), 0x10, },
> + { CCI_REG8(0x30b5), 0x70, },
> + { CCI_REG16_LE(0x30b6), 0x01f2 },
> + { CCI_REG16_LE(0x3112), 0x10 },
> + { CCI_REG16_LE(0x3116), 0x02 },
More of a discussion point ...
but should we write these as 0x0010 ? / 0x002 ?
> };
>
> static const struct cci_reg_sequence mipi_data_rate_1188Mbps[] = {
> @@ -433,25 +521,49 @@ static const u32 imx335_mbus_codes[] = {
> };
>
> /* Supported sensor mode configurations */
> -static const struct imx335_mode supported_mode = {
> - .width = 2592,
> - .height = 1944,
> - .hblank = 342,
> - .vblank = 2556,
> - .vblank_min = 2556,
> - .vblank_max = 133060,
> - .pclk = 396000000,
> - .reg_list = {
> - .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs),
> - .regs = mode_2592x1944_regs,
> - },
> - .vflip_normal = {
> - .num_of_regs = ARRAY_SIZE(mode_2592x1944_vflip_normal),
> - .regs = mode_2592x1944_vflip_normal,
> - },
> - .vflip_inverted = {
> - .num_of_regs = ARRAY_SIZE(mode_2592x1944_vflip_inverted),
> - .regs = mode_2592x1944_vflip_inverted,
> +static const struct imx335_mode supported_modes[] = {
> + {
> + .scan_mode = IMX335_ALL_PIXEL,
> + .width = 2592,
> + .height = 1944,
> + .hblank = 342,
> + .vblank = 2556,
> + .vblank_min = 2556,
> + .vblank_max = 133060,
> + .pclk = 396000000,
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs),
> + .regs = mode_2592x1944_regs,
> + },
> + .vflip_normal = {
> + .num_of_regs = ARRAY_SIZE(mode_2592x1944_vflip_normal),
> + .regs = mode_2592x1944_vflip_normal,
> + },
> + .vflip_inverted = {
> + .num_of_regs = ARRAY_SIZE(mode_2592x1944_vflip_inverted),
> + .regs = mode_2592x1944_vflip_inverted,
> + }
> + }, {
> + .scan_mode = IMX335_2_2_BINNING,
> + .width = 1312,
> + .height = 972,
> + .hblank = 155,
> + .vblank = 3528,
> + .vblank_min = 3528,
> + .vblank_max = 133060,
> + .pclk = 396000000,
> + .reg_list = {
> + .num_of_regs = ARRAY_SIZE(mode_1312x972_regs),
> + .regs = mode_1312x972_regs,
> + },
> + .vflip_normal = {
> + .num_of_regs = ARRAY_SIZE(mode_1312x972_vflip_normal),
> + .regs = mode_1312x972_vflip_normal,
> + },
> + .vflip_inverted = {
> + .num_of_regs = ARRAY_SIZE(mode_1312x972_vflip_inverted),
> + .regs = mode_1312x972_vflip_inverted,
> + },
> },
> };
>
> @@ -608,18 +720,22 @@ static int imx335_set_ctrl(struct v4l2_ctrl *ctrl)
>
> /* Propagate change of current control to all related controls */
> if (ctrl->id == V4L2_CID_VBLANK) {
> + u32 shutter_min = IMX335_SHUTTER_MIN;
> + u32 lpfr;
> +
> imx335->vblank = imx335->vblank_ctrl->val;
> + lpfr = imx335->vblank + imx335->cur_mode->height;
>
> dev_dbg(imx335->dev, "Received vblank %u, new lpfr %u\n",
> - imx335->vblank,
> - imx335->vblank + imx335->cur_mode->height);
> + imx335->vblank, lpfr);
> +
> + if (imx335->cur_mode->scan_mode == IMX335_2_2_BINNING)
> + shutter_min = IMX335_SHUTTER_MIN_BINNED;
>
> ret = __v4l2_ctrl_modify_range(imx335->exp_ctrl,
> IMX335_EXPOSURE_MIN,
> - imx335->vblank +
> - imx335->cur_mode->height -
> - IMX335_EXPOSURE_OFFSET,
> - 1, IMX335_EXPOSURE_DEFAULT);
> + lpfr - shutter_min, 1,
> + IMX335_EXPOSURE_DEFAULT);
> if (ret)
> return ret;
> }
> @@ -719,17 +835,16 @@ static int imx335_enum_frame_size(struct v4l2_subdev *sd,
> struct imx335 *imx335 = to_imx335(sd);
> u32 code;
>
> - /* Only a single supported_mode available. */
> - if (fsize->index > 0)
> + if (fsize->index >= ARRAY_SIZE(supported_modes))
> return -EINVAL;
>
> code = imx335_get_format_code(imx335, fsize->code);
> if (fsize->code != code)
> return -EINVAL;
>
> - fsize->min_width = supported_mode.width;
> + fsize->min_width = supported_modes[fsize->index].width;
> fsize->max_width = fsize->min_width;
> - fsize->min_height = supported_mode.height;
> + fsize->min_height = supported_modes[fsize->index].height;
> fsize->max_height = fsize->min_height;
>
> return 0;
> @@ -771,9 +886,13 @@ static int imx335_set_pad_format(struct v4l2_subdev *sd,
> struct imx335 *imx335 = to_imx335(sd);
> struct v4l2_mbus_framefmt *format;
> const struct imx335_mode *mode;
> + struct v4l2_rect *crop;
> int i, ret = 0;
>
> - mode = &supported_mode;
> + mode = v4l2_find_nearest_size(supported_modes,
> + ARRAY_SIZE(supported_modes),
> + width, height,
> + fmt->format.width, fmt->format.height);
>
> for (i = 0; i < ARRAY_SIZE(imx335_mbus_codes); i++) {
> if (imx335_mbus_codes[i] == fmt->format.code)
> @@ -785,6 +904,16 @@ static int imx335_set_pad_format(struct v4l2_subdev *sd,
> format = v4l2_subdev_state_get_format(sd_state, fmt->pad);
> *format = fmt->format;
>
> + crop = v4l2_subdev_state_get_crop(sd_state, fmt->pad);
> + crop->width = fmt->format.width;
> + crop->height = fmt->format.height;
> + if (mode->scan_mode == IMX335_2_2_BINNING) {
> + crop->width *= 2;
> + crop->height *= 2;
> + }
> + crop->left = (IMX335_NATIVE_WIDTH - crop->width) / 2;
> + crop->top = (IMX335_NATIVE_HEIGHT - crop->height) / 2;
> +
> if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
> ret = imx335_update_controls(imx335, mode);
> if (!ret)
> @@ -808,7 +937,7 @@ static int imx335_init_state(struct v4l2_subdev *sd,
> struct v4l2_subdev_format fmt = { 0 };
>
> fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
> - imx335_fill_pad_format(imx335, &supported_mode, &fmt);
> + imx335_fill_pad_format(imx335, &supported_modes[0], &fmt);
>
> __v4l2_ctrl_modify_range(imx335->link_freq_ctrl, 0,
> __fls(imx335->link_freq_bitmap),
> @@ -831,6 +960,11 @@ static int imx335_get_selection(struct v4l2_subdev *sd,
> struct v4l2_subdev_selection *sel)
> {
> switch (sel->target) {
> + case V4L2_SEL_TGT_CROP:
> + sel->r = *v4l2_subdev_state_get_crop(sd_state, 0);
> +
> + return 0;
> +
> case V4L2_SEL_TGT_NATIVE_SIZE:
> sel->r.top = 0;
> sel->r.left = 0;
> @@ -839,7 +973,6 @@ static int imx335_get_selection(struct v4l2_subdev *sd,
>
> return 0;
>
> - case V4L2_SEL_TGT_CROP:
> case V4L2_SEL_TGT_CROP_DEFAULT:
> case V4L2_SEL_TGT_CROP_BOUNDS:
> sel->r.top = IMX335_PIXEL_ARRAY_TOP;
> @@ -855,19 +988,35 @@ static int imx335_get_selection(struct v4l2_subdev *sd,
>
> static int imx335_set_framefmt(struct imx335 *imx335)
> {
> - switch (imx335->cur_mbus_code) {
> - case MEDIA_BUS_FMT_SRGGB10_1X10:
> - return cci_multi_reg_write(imx335->cci, raw10_framefmt_regs,
> - ARRAY_SIZE(raw10_framefmt_regs),
> - NULL);
> -
> - case MEDIA_BUS_FMT_SRGGB12_1X12:
> - return cci_multi_reg_write(imx335->cci, raw12_framefmt_regs,
> - ARRAY_SIZE(raw12_framefmt_regs),
> - NULL);
> + /*
> + * In the all-pixel scan mode the AD conversion shall match the output
> + * bit width requested.
> + *
> + * However, when 2/2 binning is enabled, the AD conversion is always
> + * 10-bit, so we ensure ADBIT is clear and ADBIT1 is assigned 0x1ff.
> + * That's as much as the documentation gives us...
> + */
> + int ret = 0;
> + u8 bpp = imx335->cur_mbus_code == MEDIA_BUS_FMT_SRGGB10_1X10 ? 10 : 12;
> + u8 ad_conv = bpp;
> +
> + /* Start with the output mode */
> + cci_write(imx335->cci, IMX335_REG_MDBIT, bpp == 12, &ret);
> +
> + /* Enforce 10 bit AD on binning modes */
> + if (imx335->cur_mode->scan_mode == IMX335_2_2_BINNING)
> + ad_conv = 10;
> +
> + /* AD Conversion configuration */
> + if (ad_conv == 10) {
> + cci_write(imx335->cci, IMX335_REG_ADBIT, 0x00, &ret);
> + cci_write(imx335->cci, IMX335_REG_ADBIT1, 0x1ff, &ret);
> + } else { /* 12 bit AD Conversion */
> + cci_write(imx335->cci, IMX335_REG_ADBIT, 0x01, &ret);
> + cci_write(imx335->cci, IMX335_REG_ADBIT1, 0x47, &ret);
> }
>
> - return -EINVAL;
> + return ret;
> }
>
> /**
> @@ -903,6 +1052,14 @@ static int imx335_start_streaming(struct imx335 *imx335)
> goto err_rpm_put;
> }
>
> + /* Write sensor common registers */
> + ret = cci_multi_reg_write(imx335->cci, imx335_common_regs,
> + ARRAY_SIZE(imx335_common_regs), NULL);
> + if (ret) {
> + dev_err(imx335->dev, "fail to write initial registers\n");
> + goto err_rpm_put;
> + }
> +
> ret = imx335_set_framefmt(imx335);
> if (ret) {
> dev_err(imx335->dev, "%s failed to set frame format: %d\n",
> @@ -1186,7 +1343,7 @@ static int imx335_init_controls(struct imx335 *imx335)
> struct v4l2_ctrl_handler *ctrl_hdlr = &imx335->ctrl_handler;
> const struct imx335_mode *mode = imx335->cur_mode;
> struct v4l2_fwnode_device_properties props;
> - u32 lpfr;
> + u32 lpfr, shutter_min;
> int ret;
>
> ret = v4l2_fwnode_device_parse(imx335->dev, &props);
> @@ -1200,11 +1357,14 @@ static int imx335_init_controls(struct imx335 *imx335)
>
> /* Initialize exposure and gain */
> lpfr = mode->vblank + mode->height;
> + shutter_min = IMX335_SHUTTER_MIN;
> + if (mode->scan_mode == IMX335_2_2_BINNING)
> + shutter_min = IMX335_SHUTTER_MIN_BINNED;
> imx335->exp_ctrl = v4l2_ctrl_new_std(ctrl_hdlr,
> &imx335_ctrl_ops,
> V4L2_CID_EXPOSURE,
> IMX335_EXPOSURE_MIN,
> - lpfr - IMX335_EXPOSURE_OFFSET,
> + lpfr - shutter_min,
> IMX335_EXPOSURE_STEP,
> IMX335_EXPOSURE_DEFAULT);
>
> @@ -1331,7 +1491,7 @@ static int imx335_probe(struct i2c_client *client)
> }
>
> /* Set default mode to max resolution */
> - imx335->cur_mode = &supported_mode;
> + imx335->cur_mode = &supported_modes[0];
> imx335->cur_mbus_code = imx335_mbus_codes[0];
> imx335->vblank = imx335->cur_mode->vblank;
>
>
> --
> 2.50.1
>
Powered by blists - more mailing lists