linux-kernel - Re: [PATCH v7 3/4] treewide: Replace 'get_task_comm()' with 'strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6e63336-aa39-dcf3-3f7c-ac90dea127b7@igalia.com>
Date: Wed, 13 Aug 2025 15:57:17 +0530
From: Bhupesh Sharma <bhsharma@...lia.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>,
 Bhupesh <bhupesh@...lia.com>
Cc: akpm@...ux-foundation.org, kernel-dev@...lia.com,
 linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
 linux-perf-users@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, oliver.sang@...el.com, lkp@...el.com,
 laoar.shao@...il.com, pmladek@...e.com, rostedt@...dmis.org,
 mathieu.desnoyers@...icios.com, arnaldo.melo@...il.com,
 alexei.starovoitov@...il.com, andrii.nakryiko@...il.com,
 mirq-linux@...e.qmqm.pl, peterz@...radead.org, willy@...radead.org,
 david@...hat.com, viro@...iv.linux.org.uk, keescook@...omium.org,
 ebiederm@...ssion.com, brauner@...nel.org, jack@...e.cz, mingo@...hat.com,
 juri.lelli@...hat.com, bsegall@...gle.com, mgorman@...e.de,
 vschneid@...hat.com, linux-trace-kernel@...r.kernel.org, kees@...nel.org,
 torvalds@...ux-foundation.org
Subject: Re: [PATCH v7 3/4] treewide: Replace 'get_task_comm()' with
 'strscpy_pad()'



On 8/11/25 8:35 PM, Andy Shevchenko wrote:
> On Mon, Aug 11, 2025 at 12:16:08PM +0530, Bhupesh wrote:
>> As Linus mentioned in [1], we should get rid of 'get_task_comm()'
>> entirely and replace it with 'strscpy_pad()' implementation.
>>
>> 'strscpy_pad()' will already make sure comm is NUL-terminated, so
>> we won't need the explicit final byte termination done in
>> 'get_task_comm()'.
>>
>> The relevant 'get_task_comm()' users were identified using the
>> following search pattern:
>>   $ git grep 'get_task_comm*'
>> [1]. https://lore.kernel.org/all/CAHk-=wi5c=_-FBGo_88CowJd_F-Gi6Ud9d=TALm65ReN7YjrMw@mail.gmail.com/
>>
>> Signed-off-by: Bhupesh <bhupesh@...lia.com>
> Make that a Link tag?
>
>    Link: https://lore.kernel.org/all/CAHk-=wi5c=_-FBGo_88CowJd_F-Gi6Ud9d=TALm65ReN7YjrMw@mail.gmail.com/ #1
>    Signed-off-by: Bhupesh <bhupesh@...lia.com>
>

Sure, will include it in next version. Waiting for further reviews on 
this v7.

Thanks.