linux-kernel - Re: [PATCH 3/4] iio: adc: ad7768-1: use devm_regulator_get_enable_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdA7hQ41Kf1yEYfnCdNbdhg0BAz0CNsQ5em+hmTwq=jag@mail.gmail.com>
Date: Wed, 13 Aug 2025 12:39:39 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Michael.Hennerich@...log.com, jic23@...nel.org, 
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, jonath4nns@...il.com
Subject: Re: [PATCH 3/4] iio: adc: ad7768-1: use devm_regulator_get_enable_read_voltage

On Wed, Aug 13, 2025 at 4:49 AM Jonathan Santos
<Jonathan.Santos@...log.com> wrote:
>
> Use devm_regulator_get_enable_read_voltage function as a standard and

..._voltage()

(Note the parentheses)

> concise way of reading the voltage from the regulator and keep the
> regulator enabled. Replace the regulator descriptor with the direct
> voltage value in the device struct.

...

>  struct ad7768_state {

>         struct spi_device *spi;
>         struct regmap *regmap;
>         struct regmap *regmap24;
> -       struct regulator *vref;
> +       int vref_uv;
>         struct regulator_dev *vcm_rdev;
>         unsigned int vcm_output_sel;
>         struct clk *mclk;

>  };

Does `pahole` agree with your arrangement?

-- 
With Best Regards,
Andy Shevchenko