linux-kernel - [PATCH] cxl: remove assignment from if condition in cxl_mem_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250813115554.388368-1-darshanrathod475@gmail.com>
Date: Wed, 13 Aug 2025 17:25:54 +0530
From: darshanrathod475@...il.com
To: dave@...olabs.net,
	jonathan.cameron@...wei.com,
	dave.jiang@...el.com,
	alison.schofield@...el.com,
	vishal.l.verma@...el.com,
	ira.weiny@...el.com,
	dan.j.williams@...el.com
Cc: shiju.jose@...wei.com,
	ming.li@...omail.com,
	peterz@...radead.org,
	linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Darshan Rathod <darshanrathod475@...il.com>
Subject: [PATCH] cxl: remove assignment from if condition in cxl_mem_get_poison

From: Darshan Rathod <darshanrathod475@...il.com>

Refactor cxl_mem_get_poison() to assign the return value of
ACQUIRE_ERR() before the conditional check, instead of performing the
assignment inside the if condition. This resolves a checkpatch.pl
warning ("do not use assignment in if condition") and improves
readability.

Signed-off-by: Darshan Rathod <darshanrathod475@...il.com>
---
 drivers/cxl/core/mbox.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index fa6dd0c94656..9c5066631896 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1426,7 +1426,9 @@ int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len,
 	int rc;
 
 	ACQUIRE(mutex_intr, lock)(&mds->poison.mutex);
-	if ((rc = ACQUIRE_ERR(mutex_intr, &lock)))
+
+	rc = ACQUIRE_ERR(mutex_intr, &lock);
+	if (rc)
 		return rc;
 
 	po = mds->poison.list_out;
-- 
2.25.1