linux-kernel - Re: [PATCH v1] ext4: fix incorrect function name in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3c2e886-3810-40b2-b2c1-fa6b27c0968d@163.com>
Date: Wed, 13 Aug 2025 20:17:10 +0800
From: liubaolin <liubaolin12138@....com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
 linux-kernel@...r.kernel.org, Baolin Liu <liubaolin@...inos.cn>
Subject: Re: [PATCH v1] ext4: fix incorrect function name in comment

> Since commit 6b730a405037 “ext4: hoist ext4_block_write_begin and replace the __block_write_begin”, the comment should be updated accordingly from '__block_write_begin' to 'ext4_block_write_begin'.


在 2025/8/13 1:20, Darrick J. Wong 写道:
> On Tue, Aug 12, 2025 at 10:17:09AM +0800, Baolin Liu wrote:
>> From: Baolin Liu <liubaolin@...inos.cn>
>>
>> The comment mentions block_write_begin(), but the actual function
>> called is ext4_block_write_begin().
>> Fix the comment to match the real function name.
>>
>> Signed-off-by: Baolin Liu <liubaolin@...inos.cn>
> 
> Heh, that comment was copy-pasted too :/
> 
> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>
> 
> --D
> 
>> ---
>>   fs/ext4/inode.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index ed54c4d0f2f9..b0e3814f8502 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -3155,7 +3155,7 @@ static int ext4_da_write_begin(const struct kiocb *iocb,
>>   		folio_unlock(folio);
>>   		folio_put(folio);
>>   		/*
>> -		 * block_write_begin may have instantiated a few blocks
>> +		 * ext4_block_write_begin may have instantiated a few blocks
>>   		 * outside i_size.  Trim these off again. Don't need
>>   		 * i_size_read because we hold inode lock.
>>   		 */
>> -- 
>> 2.39.2
>>
>>