linux-kernel - Re: [PATCH] maple_tree: Remove redundant semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2703fdf-0c51-43e1-8df2-16feb1d245d9@vivo.com>
Date: Thu, 14 Aug 2025 10:10:53 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 "open list:LIBRARY CODE" <linux-kernel@...r.kernel.org>,
 "open list:MAPLE TREE" <maple-tree@...ts.infradead.org>,
 "open list:MAPLE TREE" <linux-mm@...ck.org>
Subject: Re: [PATCH] maple_tree: Remove redundant semicolons

On 8/13/2025 10:02 PM, Liam R. Howlett wrote:

> * Liao Yuanhong <liaoyuanhong@...o.com> [250813 05:46]:
>> Remove unnecessary semicolons.
> Thanks!
>
> One nit, it would have been good to state that this is a test code
> change in the subject.  Usually I use "test_maple_tree:" or something
> like "maple_tree: Remove redundant semicolon from test code".
>
> Please mention test in the subject next time.

OK, I will pay attention to similar submissions next time.

Thanks,

Liao

>
>> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
>
>> ---
>>   lib/test_maple_tree.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
>> index cb3936595b0d..1433ecc854cb 100644
>> --- a/lib/test_maple_tree.c
>> +++ b/lib/test_maple_tree.c
>> @@ -3562,7 +3562,7 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
>>   	MT_BUG_ON(mt, mas.last != 0x1500);
>>   	MT_BUG_ON(mt, !mas_is_active(&mas));
>>   
>> -	/* find: start ->active on value */;
>> +	/* find: start ->active on value */
>>   	mas_set(&mas, 1200);
>>   	entry = mas_find(&mas, ULONG_MAX);
>>   	MT_BUG_ON(mt, entry != ptr);
>> -- 
>> 2.34.1
>>