linux-kernel - Re: [PATCH 1/2] ASoC: es8323: enable right-hand DAC-mixer connection on ES8323

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5a64166-c55f-4ca4-af92-52c954847af6@sirena.org.uk>
Date: Thu, 14 Aug 2025 13:11:59 +0100
From: Mark Brown <broonie@...nel.org>
To: Shimrra Shai <shimrrashai@...il.com>
Cc: lgirdwood@...il.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	perex@...ex.cz, tiwai@...e.com
Subject: Re: [PATCH 1/2] ASoC: es8323: enable right-hand DAC-mixer connection
 on ES8323

On Wed, Aug 13, 2025 at 08:47:31PM -0500, Shimrra Shai wrote:
> Enable the right-hand DAC mixer connection in the same manner as the
> left-hand one.

> @@ -633,6 +633,7 @@ static int es8323_probe(struct snd_soc_component *component)
>  	snd_soc_component_write(component, ES8323_CONTROL2, 0x60);
>  	snd_soc_component_write(component, ES8323_CHIPPOWER, 0x00);
>  	snd_soc_component_write(component, ES8323_DACCONTROL17, 0xB8);
> +	snd_soc_component_write(component, ES8323_DACCONTROL20, 0xB8);

Neither of these should be unconditional writes, these should be user
visible controls.  We don't encode specific system's use cases into the
driver.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)