linux-kernel - Re: [PATCH 3/3] eeprom: at25: make FRAM device ID error message more precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c04e14269f1462a76ba0b4f42f90501ef57913c.camel@gmail.com>
Date: Thu, 14 Aug 2025 14:25:27 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Markus Heidelberg <m.heidelberg@....de>, Arnd Bergmann <arnd@...db.de>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devicetree@...r.kernel.org
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Christian Eggers <ceggers@...i.de>,
 Jiri Prchal <jiri.prchal@...ignal.cz>, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] eeprom: at25: make FRAM device ID error message
 more precise

On Thu, 2025-08-14 at 13:15 +0200, Markus Heidelberg wrote:
> The error description would be wrong in case the "size" Devicetree
> property is missing for an FRAM without device ID.
> 
> Signed-off-by: Markus Heidelberg <m.heidelberg@....de>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

> ---
>  drivers/misc/eeprom/at25.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index c90150f72836..e2868f7bdb03 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -399,7 +399,7 @@ static int at25_fram_to_chip(struct device *dev, struct spi_eeprom *chip)
>  				id[j] = tmp;
>  			}
>  		if (id[6] != 0xc2) {
> -			dev_err(dev, "Error: no Cypress FRAM (id %02x)\n", id[6]);
> +			dev_err(dev, "Error: no Cypress FRAM with device ID (manufacturer ID bank 7: %02x)\n", id[6]);
>  			return -ENODEV;
>  		}

-- 
Alexander Sverdlin.