linux-kernel - Re: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wm76t6qu.wl-tiwai@suse.de>
Date: Thu, 14 Aug 2025 14:42:01 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Xu, Baojun" <baojun.xu@...com>
Cc: "broonie@...nel.org" <broonie@...nel.org>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"Ding, Shenghao"
	<shenghao-ding@...com>,
	"13916275206@....com" <13916275206@....com>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name

On Thu, 14 Aug 2025 08:32:18 +0200,
Takashi Iwai wrote:
> 
> On Thu, 14 Aug 2025 04:29:10 +0200,
> Xu, Baojun wrote:
> > 
> > Hi,
> > 
> > Answer in line.
> > 
> > > ________________________________________
> > > From: Takashi Iwai <tiwai@...e.de>
> > > Sent: 13 August 2025 23:44
> > > To: Xu, Baojun
> > > Cc: broonie@...nel.org; andriy.shevchenko@...ux.intel.com; alsa-devel@...a-project.org; Ding, Shenghao; 13916275206@....com; linux-sound@...r.kernel.org; linux-kernel@...r.kernel.org
> > > Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name
> > > 
> > > On Wed, 13 Aug 2025 12:08:42 +0200,
> > > Baojun Xu wrote:
> > > >
> > > > Change the name of the kcontrol from "Gain" to "Volume".
> > > 
> > > Could you describe "why this change is needed"?
> > > 
> > This name is in kcontrol, which is open to users.
> > Volume is more normalized and common.
> > Gain is a more professional term in smart amplifiers.
> 
> But did you realize that changing the control name may change the
> user-space behavior completely?
> e.g. alsa-lib implementation tries to group control elements per
> prefix and suffix, and "Volume" is one of the standard suffix.
> That is, with this change, it'll appear as "Speaker Analog" as a mixer
> element name where the former name is "Speaker Analog Gain".
> 
> I'm not against the proposed rename.  But please remember that control
> names aren't something you can change easily because you don't feel
> good; it's a thing to be more or less "fixed" once after defined in
> the release products.

Nevertheless I applied the patch now, as Mark already took for ASoC
side.


thanks,

Takashi