linux-kernel - Re: [PATCH v2] drm/nouveau/gsp: fix mismatched alloc/free for kvmalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a11bd516-7ebb-4865-9e19-394ee4a5be37@web.de>
Date: Thu, 14 Aug 2025 14:41:07 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Qianfeng Rong <rongqianfeng@...o.com>, nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Danilo Krummrich <dakr@...nel.org>,
 Dave Airlie <airlied@...hat.com>, Lyude Paul <lyude@...hat.com>,
 Simona Vetter <simona@...ll.ch>, Timur Tabi <ttabi@...dia.com>,
 Zhi Wang <zhiw@...dia.com>
Cc: LKML <linux-kernel@...r.kernel.org>, David Airlie <airlied@...il.com>
Subject: Re: [PATCH v2] drm/nouveau/gsp: fix mismatched alloc/free for
 kvmalloc()

> Replace kfree() with kvfree() for memory allocated by kvmalloc().

* Would you like to improve the exception handling by using another goto chain?

* How do you think about to increase the application of scope-based resource management?
  https://elixir.bootlin.com/linux/v6.16/source/include/linux/slab.h#L1081

Is there a need to adjust also the following statement combination?
https://elixir.bootlin.com/linux/v6.16/source/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/rpc.c#L312-L314

…
		kvfree(info.gsp_rpc_buf);
		info.gsp_rpc_buf = NULL;
		return buf;
…

Regards,
Markus