linux-kernel - Re: [PATCH v1] HID: Asus: add Z13 folio to generic group for multitouch to work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwEJyTt_5yri5zj3W1VURNUJr=HQzPOf1dP619NVtEL-pA@mail.gmail.com>
Date: Thu, 14 Aug 2025 15:04:25 +0200
From: Antheas Kapenekakis <lkml@...heas.dev>
To: inux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>, "Luke D . Jones" <luke@...nes.dev>
Subject: Re: [PATCH v1] HID: Asus: add Z13 folio to generic group for
 multitouch to work

I will slowly start breaking up the Asus WMI series I sent earlier in
the year so it can slowly start going through.

This quirk can merge to stable too, so I will start with it first. I
am compile testing it for 6.17rc1 atm if there are any issues I will
report back.

Antheas

On Thu, 14 Aug 2025 at 15:02, Antheas Kapenekakis <lkml@...heas.dev> wrote:
>
> The Asus Z13 folio has a multitouch touchpad that needs to bind
> to the hid-multitouch driver in order to work properly. So bind
> it to the HID_GROUP_GENERIC group to release the touchpad and
> move it to the bottom so that the comment applies to it.
>
> While at it, change the generic KEYBOARD3 name to Z13_FOLIO.
>
> Reviewed-by: Luke D. Jones <luke@...nes.dev>
> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
> ---
>  drivers/hid/hid-asus.c | 6 +++---
>  drivers/hid/hid-ids.h  | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 4b45e31f0bab..10b2f9ff78a3 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -1378,9 +1378,6 @@ static const struct hid_device_id asus_devices[] = {
>         { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
>             USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD2),
>           QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
> -       { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
> -           USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3),
> -         QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
>         { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,
>             USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR),
>           QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
> @@ -1410,6 +1407,9 @@ static const struct hid_device_id asus_devices[] = {
>          * Note bind to the HID_GROUP_GENERIC group, so that we only bind to the keyboard
>          * part, while letting hid-multitouch.c handle the touchpad.
>          */
> +       { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +               USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_Z13_FOLIO),
> +         QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>                 USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD) },
>         { }
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5a1096283855..cff7d95c8d59 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -223,7 +223,7 @@
>  #define USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD3 0x1822
>  #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD        0x1866
>  #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD2       0x19b6
> -#define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3       0x1a30
> +#define USB_DEVICE_ID_ASUSTEK_ROG_Z13_FOLIO            0x1a30
>  #define USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR         0x18c6
>  #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY            0x1abe
>  #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY_X          0x1b4c
>
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> --
> 2.50.1
>
>