linux-kernel - [PATCH] media: atomisp: Use vmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250814133032.236533-1-rongqianfeng@vivo.com>
Date: Thu, 14 Aug 2025 21:30:29 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Andy Shevchenko <andy@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans Verkuil <hverkuil@...nel.org>,
	linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Cc: Qianfeng Rong <rongqianfeng@...o.com>
Subject: [PATCH] media: atomisp: Use vmemdup_user() instead of open-coding

Use vmemdup_user() to get a copy of the user buffer in
atomisp_v4l2_framebuffer_to_css_frame().

Compile-tested only.

Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 3a4eb4f6d3be..d6fa1605a096 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -3326,14 +3326,10 @@ atomisp_v4l2_framebuffer_to_css_frame(const struct v4l2_framebuffer *arg,
 		goto err;
 	}
 
-	tmp_buf = vmalloc(arg->fmt.sizeimage);
-	if (!tmp_buf) {
-		ret = -ENOMEM;
-		goto err;
-	}
-	if (copy_from_user(tmp_buf, (void __user __force *)arg->base,
-			   arg->fmt.sizeimage)) {
-		ret = -EFAULT;
+	tmp_buf = vmemdup_user((void __user __force *)arg->base,
+			       arg->fmt.sizeimage);
+	if (IS_ERR(tmp_buf)) {
+		ret = PTR_ERR(tmp_buf);
 		goto err;
 	}
 
@@ -3345,7 +3341,8 @@ atomisp_v4l2_framebuffer_to_css_frame(const struct v4l2_framebuffer *arg,
 err:
 	if (ret && res)
 		ia_css_frame_free(res);
-	vfree(tmp_buf);
+	if (!IS_ERR(tmp_buf))
+		kvfree(tmp_buf);
 	if (ret == 0)
 		*result = res;
 	return ret;
-- 
2.34.1