linux-kernel - Re: [RFC PATCH] sched: psi: Add psi events trace point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250814135501.GD115258@cmpxchg.org>
Date: Thu, 14 Aug 2025 09:55:01 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Xuewen Yan <xuewen.yan@...soc.com>
Cc: rostedt@...dmis.org, surenb@...gle.com, peterz@...radead.org,
	mingo@...hat.com, mhiramat@...nel.org,
	mathieu.desnoyers@...icios.com, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	bsegall@...gle.com, andrii@...nel.org, vschneid@...hat.com,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	yuming.han@...soc.com, ke.wang@...soc.com, xuewen.yan94@...il.com
Subject: Re: [RFC PATCH] sched: psi: Add psi events trace point

On Thu, Aug 14, 2025 at 03:07:19PM +0800, Xuewen Yan wrote:
> Add trace point to psi triggers. This is useful to
> observe the psi events in the kernel space.
> 
> Signed-off-by: Xuewen Yan <xuewen.yan@...soc.com>

Can you elaborate on a situation in which you would use this?

> ---
>  include/trace/events/sched.h | 5 +++++
>  kernel/sched/psi.c           | 2 ++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index 7b2645b50e78..c23cb2bc76fd 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -896,6 +896,11 @@ DECLARE_TRACE(sched_set_need_resched,
>  	TP_PROTO(struct task_struct *tsk, int cpu, int tif),
>  	TP_ARGS(tsk, cpu, tif));
>  
> +struct psi_trigger *t

Missing ;

> +DECLARE_TRACE(psi_event,
> +	TP_PROTO(struct psi_trigger *t),
> +	TP_ARGS(t));
> +
>  #endif /* _TRACE_SCHED_H */
>  
>  /* This part must be outside protection */