linux-kernel - Re: [PATCH v2 4/9] mfd: dt-bindings: ti,twl4030-power: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814161055.332a829a@akair>
Date: Thu, 14 Aug 2025 16:10:55 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>
Cc: linux-kernel@...r.kernel.org, peter.ujfalusi@...il.com,
 dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 lgirdwood@...il.com, tiwai@...e.com, conor+dt@...nel.org, lee@...nel.org,
 ukleinek@...nel.org, broonie@...nel.org, gregkh@...uxfoundation.org,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-usb@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v2 4/9] mfd: dt-bindings: ti,twl4030-power: convert to
 DT schema

Am Thu, 14 Aug 2025 15:21:24 +0200
schrieb Jihed Chaibi <jihed.chaibi.dev@...il.com>:

> Convert the legacy TXT binding for the TWL4030 power module
> to the modern YAML DT schema format. This adds formal validation
> and improves documentation.
> 
> Changes in v2:
> Simplified the description field by removing redundant '|' as it
> does not affect formatting in this context.
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> ---
>  .../bindings/mfd/ti,twl4030-power.yaml        | 69 +++++++++++++++++++
>  .../devicetree/bindings/mfd/twl4030-power.txt | 48 -------------
>  2 files changed, 69 insertions(+), 48 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,twl4030-power.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl4030-power.yaml b/Documentation/devicetree/bindings/mfd/ti,twl4030-power.yaml
> new file mode 100644
> index 000000000..713e2facf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl4030-power.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,twl4030-power.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TWL4030-family Power Management Module
> +
> +maintainers:
> +  - Peter Ujfalusi <peter.ujfalusi@...il.com>
> +
> +description:
> +  The power management module inside the TWL family provides several facilities
> +  to control the power resources, including power scripts. For now, the
> +  binding only supports the complete shutdown of the system after poweroff.
> +
> +properties:
> +  compatible:
> +    description: |
> +      The compatible string determines the specific power configuration.
> +        "ti,twl4030-power": Standard power control.
> +        "ti,twl4030-power-reset": Recommended for OMAP3530 and similar SoCs
> +          that require a special configuration for warm reset to work correctly.
> +        "ti,twl4030-power-idle": Loads the TI-recommended configuration for
> +          idle modes into the PMIC.
> +        "ti,twl4030-power-idle-osc-off": Uses the recommended idle configuration
> +          but also shuts down the external oscillator. This may not work on all
> +          boards depending on the oscillator wiring.
> +
> +    enum:
> +      - ti,twl4030-power
> +      - ti,twl4030-power-reset
> +      - ti,twl4030-power-idle
> +      - ti,twl4030-power-idle-osc-off
> +
yes, this is ugly use of compatible, but not easy being patched away.

> +  ti,system-power-controller:
> +    type: boolean
> +    description:
> +      Indicates that the TWL4030 is the power supply master of the system,
> +      allowing it to initiate system power-off.
> +
this too is deprecated, we already have the system-power-controller
node in the parent.

> +  ti,use_poweroff:
> +    type: boolean
> +    description: Deprecated name for ti,system-power-controller.
> +    deprecated: true
> +
I think we can even totally drop this and maybe add this whole stuff to
ti,twl.yaml, no extra file.

Regards,
Andreas