linux-kernel - Re: [PATCH 0/2] clk: thead: th1520-ap: allow gate cascade and fix padctrl0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTQXR9W6G5ygvGVdH_iiynZ85E3c_XJ4HKj+_wWMnRpkpw@mail.gmail.com>
Date: Thu, 14 Aug 2025 11:10:13 +0800
From: Guo Ren <guoren@...nel.org>
To: Icenowy Zheng <uwu@...nowy.me>
Cc: Drew Fustini <fustini@...nel.org>, Fu Wei <wefu@...hat.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Michal Wilczynski <m.wilczynski@...sung.com>, Yao Zi <ziyao@...root.org>, 
	Han Gao <rabenda.cn@...il.com>, linux-riscv@...ts.infradead.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] clk: thead: th1520-ap: allow gate cascade and fix padctrl0

Thanks for the fixup, don't forget the "Fixes" tag and Cc stable@...nel.org.

Others LGTM!

Reviewed-by: Guo Ren <guoren@...nel.org>

On Thu, Aug 14, 2025 at 1:16 AM Icenowy Zheng <uwu@...nowy.me> wrote:
>
> 在 2025-08-14星期四的 01:11 +0800，Icenowy Zheng写道：
> > Current ccu_gate implementation does not easily allow gates to be
> > clock
> > parents because of the waste of struct clk_hw in struct ccu_gate;
> > however it's found that the padctrl0 apb clock gate seems to be
> > downstream of perisys-apb4-hclk, gating the latter w/o gating the
> > former
> > makes the padctrl0 registers inaccessible too.
> >
> > Fix this by refactor ccu_gate code, mimicing what Yao Zi did on
> > ccu_mux; and then assign perisys-apb4-hclk as parent of padctrl0 bus
> > gate.
>
> Forgot to mention a easy test of this patchset:
>
> Just install `gpioset` from `libgpiod` on a Lichee Pi 4A, plug a fan to
> its fan port, and run `gpioset 3 3=1`. The expected behavior is the fan
> starts to spin (because GPIO3_3 is the pin controlling the fan),
> however without this patchset Linux will fail to switch that pin.
>
> >
> > This patchset depends on the display clock patchset at [1], although
> > a
> > rebasing to get rid of this dependency is possible.
> >
> > [1]
> > https://lore.kernel.org/linux-riscv/20250813072702.2176993-1-uwu@icenowy.me/
> >
> > Icenowy Zheng (2):
> >   clk: thead: th1520-ap: describe gate clocks with clk_gate
> >   clk: thead: th1520-ap: fix parent of padctrl0 clock
> >
> >  drivers/clk/thead/clk-th1520-ap.c | 385 +++++++++++++++-------------
> > --
> >  1 file changed, 188 insertions(+), 197 deletions(-)
> >
>


-- 
Best Regards
 Guo Ren