linux-kernel - Re: [PATCH V4 0/3] Mask the replay timer timeout of AER for GL9763e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK00qKBzeXJMkYsz7zZTkLDgQ=EAoHvOzPrzmAbJeyUsMZZq0g@mail.gmail.com>
Date: Thu, 14 Aug 2025 22:11:29 +0800
From: Victor Shih <victorshihgli@...il.com>
To: ulf.hansson@...aro.org, adrian.hunter@...el.com
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	benchuanggli@...il.com, ben.chuang@...esyslogic.com.tw, 
	HL.Liu@...esyslogic.com.tw, Victor Shih <victor.shih@...esyslogic.com.tw>
Subject: Re: [PATCH V4 0/3] Mask the replay timer timeout of AER for GL9763e

Hi, Ulf

I'm embarrassed to bother you, but could you help to  please review
this series of patches?
If there are any parts that need to be modified, please let me know.

Thanks, Victor Shih


On Thu, Jul 31, 2025 at 2:57 PM Victor Shih <victorshihgli@...il.com> wrote:
>
> From: Victor Shih <victor.shih@...esyslogic.com.tw>
>
> These patches add a sdhci_gli_mask_replay_timer_timeout() function
> to simplify some of the code and mask the replay timer timeout of AER
> for the GL9763e chipset.
>
> Changes in v4 (July. 31, 2025)
> * Rebase on latest mmc/next.
> * Patch#2: Add new message to the commit message to explain
>            why it has a stable tag.
>
> ----------------- original cover letter from v3 -----------------
> These patches add a sdhci_gli_mask_replay_timer_timeout() function
> to simplify some of the code and mask the replay timer timeout of AER
> for the GL9763e chipset.
>
> Changes in v3 (July. 29, 2025)
> * Rebase on latest mmc/next.
> * Split patch#2 in V2 into patch#2 and patch#3.
> * Patch#1: Correct the wrong parameters in the
>            sdhci_gli_mask_replay_timer_timeout() function.
>            Add new message to the commit message to explain
>            why it has a stable tag.
>            Add fixes tag to the commit message.
> * Patch#2: Add fixes tag to the commit message.
> * Patch#3: Add fixes tag to the commit message.
>
> ----------------- original cover letter from v2 -----------------
> These patches add a sdhci_gli_mask_replay_timer_timeout() function
> to simplify some of the code and mask the replay timer timeout of AER
> for the GL9763e chipset.
>
> Changes in v2 (July. 25, 2025)
> * Rebase on latest mmc/next.
> * Patch#1: Add a sdhci_gli_mask_replay_timer_timeout() function
>            to simplify some of the code.
> * Patch#2: Mask replay timer timeout of AER for the GL9763e.
> * Patch#2: Rename the gli_set_gl9763e() to gl9763e_hw_setting()
>            for consistency.
>
> ----------------- original cover letter from v1 -----------------
> Due to a flaw in the hardware design, the GL9763e replay timer frequently
> times out when ASPM is enabled. As a result, the warning messages will
> often appear in the system log when the system accesses the GL9763e
> PCI config. Therefore, the replay timer timeout must be masked.
>
> Changes in v1 (July. 16, 2025)
> * Rebase on latest mmc/next.
> * Mask replay timer timeout of AER for the GL9763e.
>
> Victor Shih (3):
>   mmc: sdhci-pci-gli: Add a new function to simplify the code
>   mmc: sdhci-pci-gli: GL9763e: Rename the gli_set_gl9763e() for
>     consistency
>   mmc: sdhci-pci-gli: GL9763e: Mask the replay timer timeout of AER
>
>  drivers/mmc/host/sdhci-pci-gli.c | 37 ++++++++++++++++++--------------
>  1 file changed, 21 insertions(+), 16 deletions(-)
>
> --
> 2.43.0
>