linux-kernel - Re: [PATCH v2 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document SC7280 PCIe0 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <yncizuu6bhr3xvuzkb5xri4gh6mdjg4r4d4nkufgxxpquetyir@kiagpup6wqgx>
Date: Thu, 14 Aug 2025 09:16:43 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
Cc: Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	cros-qcom-dts-watchers@...omium.org, Konrad Dybcio <konradybcio@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy:
 Document SC7280 PCIe0 phy

On Tue, Aug 12, 2025 at 07:26:44PM +0530, Krishna Chaitanya Chundru wrote:
> SC7280 PCIe0 PHY is functionally compatible with the SM8250 Gen3 x1 PCIe
> PHY. To reflect this compatibility, update the binding schema to include
      ^--- I think here would be a good place to break for a new
           paragraph, to give separation between problem description and
	   solution description.

> qcom,sc7280-qmp-gen3x1-pcie-phy using enum within a oneOf block, while
> retaining qcom,sm8250-qmp-gen3x1-pcie-phy as a const.
> 

Isn't this the case for &pcie1 as well? If so, can you please fix both?


Also, before we do that, the fact that they are "functionally
compatible", can you confirm that these two platforms really has the
same PHY settings?

Regards,
Bjorn

> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
> ---
>  .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml   | 69 ++++++++++++----------
>  1 file changed, 37 insertions(+), 32 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> index a1ae8c7988c891a11f6872e58d25e9d04abb41ce..1e08e26892f7b769b75bb905377d30a301e6631c 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> @@ -15,38 +15,43 @@ description:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,qcs615-qmp-gen3x1-pcie-phy
> -      - qcom,qcs8300-qmp-gen4x2-pcie-phy
> -      - qcom,sa8775p-qmp-gen4x2-pcie-phy
> -      - qcom,sa8775p-qmp-gen4x4-pcie-phy
> -      - qcom,sar2130p-qmp-gen3x2-pcie-phy
> -      - qcom,sc8180x-qmp-pcie-phy
> -      - qcom,sc8280xp-qmp-gen3x1-pcie-phy
> -      - qcom,sc8280xp-qmp-gen3x2-pcie-phy
> -      - qcom,sc8280xp-qmp-gen3x4-pcie-phy
> -      - qcom,sdm845-qhp-pcie-phy
> -      - qcom,sdm845-qmp-pcie-phy
> -      - qcom,sdx55-qmp-pcie-phy
> -      - qcom,sdx65-qmp-gen4x2-pcie-phy
> -      - qcom,sm8150-qmp-gen3x1-pcie-phy
> -      - qcom,sm8150-qmp-gen3x2-pcie-phy
> -      - qcom,sm8250-qmp-gen3x1-pcie-phy
> -      - qcom,sm8250-qmp-gen3x2-pcie-phy
> -      - qcom,sm8250-qmp-modem-pcie-phy
> -      - qcom,sm8350-qmp-gen3x1-pcie-phy
> -      - qcom,sm8350-qmp-gen3x2-pcie-phy
> -      - qcom,sm8450-qmp-gen3x1-pcie-phy
> -      - qcom,sm8450-qmp-gen4x2-pcie-phy
> -      - qcom,sm8550-qmp-gen3x2-pcie-phy
> -      - qcom,sm8550-qmp-gen4x2-pcie-phy
> -      - qcom,sm8650-qmp-gen3x2-pcie-phy
> -      - qcom,sm8650-qmp-gen4x2-pcie-phy
> -      - qcom,x1e80100-qmp-gen3x2-pcie-phy
> -      - qcom,x1e80100-qmp-gen4x2-pcie-phy
> -      - qcom,x1e80100-qmp-gen4x4-pcie-phy
> -      - qcom,x1e80100-qmp-gen4x8-pcie-phy
> -      - qcom,x1p42100-qmp-gen4x4-pcie-phy
> +    oneOf:
> +      - items:
> +          - const: qcom,sc7280-qmp-gen3x1-pcie-phy
> +          - const: qcom,sm8250-qmp-gen3x1-pcie-phy
> +      - items:
> +          - enum:
> +              - qcom,qcs615-qmp-gen3x1-pcie-phy
> +              - qcom,qcs8300-qmp-gen4x2-pcie-phy
> +              - qcom,sa8775p-qmp-gen4x2-pcie-phy
> +              - qcom,sa8775p-qmp-gen4x4-pcie-phy
> +              - qcom,sar2130p-qmp-gen3x2-pcie-phy
> +              - qcom,sc8180x-qmp-pcie-phy
> +              - qcom,sc8280xp-qmp-gen3x1-pcie-phy
> +              - qcom,sc8280xp-qmp-gen3x2-pcie-phy
> +              - qcom,sc8280xp-qmp-gen3x4-pcie-phy
> +              - qcom,sdm845-qhp-pcie-phy
> +              - qcom,sdm845-qmp-pcie-phy
> +              - qcom,sdx55-qmp-pcie-phy
> +              - qcom,sdx65-qmp-gen4x2-pcie-phy
> +              - qcom,sm8150-qmp-gen3x1-pcie-phy
> +              - qcom,sm8150-qmp-gen3x2-pcie-phy
> +              - qcom,sm8250-qmp-gen3x1-pcie-phy
> +              - qcom,sm8250-qmp-gen3x2-pcie-phy
> +              - qcom,sm8250-qmp-modem-pcie-phy
> +              - qcom,sm8350-qmp-gen3x1-pcie-phy
> +              - qcom,sm8350-qmp-gen3x2-pcie-phy
> +              - qcom,sm8450-qmp-gen3x1-pcie-phy
> +              - qcom,sm8450-qmp-gen4x2-pcie-phy
> +              - qcom,sm8550-qmp-gen3x2-pcie-phy
> +              - qcom,sm8550-qmp-gen4x2-pcie-phy
> +              - qcom,sm8650-qmp-gen3x2-pcie-phy
> +              - qcom,sm8650-qmp-gen4x2-pcie-phy
> +              - qcom,x1e80100-qmp-gen3x2-pcie-phy
> +              - qcom,x1e80100-qmp-gen4x2-pcie-phy
> +              - qcom,x1e80100-qmp-gen4x4-pcie-phy
> +              - qcom,x1e80100-qmp-gen4x8-pcie-phy
> +              - qcom,x1p42100-qmp-gen4x4-pcie-phy
>  
>    reg:
>      minItems: 1
> 
> -- 
> 2.34.1
>