linux-kernel - Re: [PATCH v2 15/24] media: iris: Add support for VIDIOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a54af278-6c99-9420-72ed-f4abab519216@quicinc.com>
Date: Thu, 14 Aug 2025 20:16:11 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
        Abhinav Kumar
	<abhinav.kumar@...ux.dev>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil
	<hverkuil@...all.nl>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        "Vedang
 Nagar" <quic_vnagar@...cinc.com>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Renjiang Han <quic_renjiang@...cinc.com>,
        Wangao Wang <quic_wangaow@...cinc.com>
Subject: Re: [PATCH v2 15/24] media: iris: Add support for VIDIOC_QUERYCAP for
 encoder video device


On 8/13/2025 3:08 PM, Dikshita Agarwal wrote:
> Add support for the VIDIOC_QUERYCAP V4L2 iocts for the encoder video
> device to report core driver capabilities.
> 
> Tested-by: Vikash Garodia <quic_vgarodia@...cinc.com> # X1E80100
> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> ---
>  drivers/media/platform/qcom/iris/iris_vidc.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
> index cb1280c0c6c82187243f0bda4d98e42370ee787c..458773a2ed7f5e16d5bd5e79dba2f5c029036505 100644
> --- a/drivers/media/platform/qcom/iris/iris_vidc.c
> +++ b/drivers/media/platform/qcom/iris/iris_vidc.c
> @@ -446,8 +446,14 @@ static int iris_enum_frameintervals(struct file *filp, void *fh,
>  
>  static int iris_querycap(struct file *filp, void *fh, struct v4l2_capability *cap)
>  {
> +	struct iris_inst *inst = iris_get_inst(filp, NULL);
> +
>  	strscpy(cap->driver, IRIS_DRV_NAME, sizeof(cap->driver));
> -	strscpy(cap->card, "Iris Decoder", sizeof(cap->card));
> +
> +	if (inst->domain == DECODER)
> +		strscpy(cap->card, "Iris Decoder", sizeof(cap->card));
> +	else
> +		strscpy(cap->card, "Iris Encoder", sizeof(cap->card));
>  
>  	return 0;
>  }
> @@ -577,6 +583,7 @@ static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops_enc = {
>  	.vidioc_g_fmt_vid_out_mplane    = iris_g_fmt_vid_mplane,
>  	.vidioc_enum_framesizes         = iris_enum_framesizes,
>  	.vidioc_enum_frameintervals     = iris_enum_frameintervals,
> +	.vidioc_querycap                = iris_querycap,
>  };
>  
>  void iris_init_ops(struct iris_core *core)
> 

Reviewed-by: Vikash Garodia <quic_vgarodia@...cinc.com>