linux-kernel - Re: [ISSUE + PATCH] Interrupts were enabled early by spinlock guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62be0896-6c90-4a27-81cb-7bd897d0e6f2@grenoble.cnrs.fr>
Date: Thu, 14 Aug 2025 17:28:57 +0200
From: Edgar Bonet <bonet@...noble.cnrs.fr>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Huacai Chen <chenhuacai@...nel.org>,
 Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [ISSUE + PATCH] Interrupts were enabled early by spinlock guard

Hello Geert, and thanks for you prompt review!

> I think the conversions in
> drivers/irqchip/irq-atmel-aic.c:aic_irq_domain_xlate() and
> drivers/irqchip/irq-loongson-liointc.c:liointc_set_type()
> are also wrong, and need a similar change.

The one in irq-atmel-aic.c looks indeed strikingly similar. The one in
irq-loongson-liointc.c is slightly different though. Instead of:

    irq_gc_lock_irqsave() -> guard(raw_spinlock_irq)

it does:

    irq_gc_lock_irqsave() -> guard(raw_spinlock)

I don't know what the implications are though.

> Unfortunately I have no hardware to verify.

Neither do I.

Regards,

Edgar.