linux-kernel - Re: [PATCH v5 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250814153807.12834-1-ramiserifpersia@gmail.com>
Date: Thu, 14 Aug 2025 17:38:07 +0200
From: Šerif Rami <ramiserifpersia@...il.com>
To: ramiserifpersia@...il.com
Cc: linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org,
	perex@...ex.cz,
	tiwai@...e.com
Subject: Re: [PATCH v5 0/7] ALSA: usb-audio: Add driver for TASCAM US-144MKII

Hi,

While reviewing my v5 series, I noticed that the default values for the
digital in/out kcontrols were lost during patch splitting. They should
default to 1 (currently 0), which is incorrect for these controls.

us144mkii.c:

@@ -489,6 +489,8 @@ static int tascam_probe(struct usb_interface *intf,
 	tascam->dev = usb_get_dev(dev);
 	tascam->card = card;
 	tascam->iface0 = intf;
+	tascam->digital_out_source = 1;
+	tascam->capture_34_source = 1;

I will restore these defaults in the appropriate patch in the next revision.

Thanks,
Šerif