linux-kernel - Re: [PATCH] clk: renesas: r9a09g077: Add module clocks for SCI1-SCI5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8smWQaYvt+kbRb_tmhH+-2Zt+eag=unJECH=xSUzjRrRQ@mail.gmail.com>
Date: Thu, 14 Aug 2025 16:41:16 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] clk: renesas: r9a09g077: Add module clocks for SCI1-SCI5

Hi Geert,

Thank you for the review.

On Thu, Aug 14, 2025 at 4:23 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, 12 Aug 2025 at 19:17, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Add asynchronous core clocks and module clocks for SCI channels 1
> > through 5 on the RZ/T2H SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/clk/renesas/r9a09g077-cpg.c
> > +++ b/drivers/clk/renesas/r9a09g077-cpg.c
> > @@ -48,6 +48,11 @@
> >  #define DIVCA55S       CONF_PACK(SCKCR2, 12, 1)
> >
> >  #define DIVSCI0ASYNC   CONF_PACK(SCKCR3, 6, 2)
> > +#define DIVSCI1ASYNC   CONF_PACK(SCKCR3, 8, 2)
> > +#define DIVSCI2ASYNC   CONF_PACK(SCKCR3, 10, 2)
> > +#define DIVSCI3ASYNC   CONF_PACK(SCKCR3, 12, 2)
> > +#define DIVSCI4ASYNC   CONF_PACK(SCKCR3, 14, 2)
> > +#define DIVSCI5ASYNC   CONF_PACK(SCKCR2, 18, 2)
>
> Please move the last one to the previous block, next to the other
> SCKCR2 definitions.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> i.e. will queue in renesas-clk for v6.18, with the above fixed.
>
Thanks for taking care of it.

Cheers,
Prabhakar