linux-kernel - Re: [PATCH v4 15/15] rnull: add soft-irq completion support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wm75ep0f.fsf@t14s.mail-host-address-is-not-set>
Date: Thu, 14 Aug 2025 20:28:48 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Boqun Feng <boqun.feng@...il.com>, Miguel Ojeda <ojeda@...nel.org>, Alex
 Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy
 Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, Trevor
 Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, Jens Axboe
 <axboe@...nel.dk>, linux-block@...r.kernel.org,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 15/15] rnull: add soft-irq completion support

"Alice Ryhl" <aliceryhl@...gle.com> writes:

> On Tue, Aug 12, 2025 at 10:44:33AM +0200, Andreas Hindborg wrote:
>> rnull currently only supports direct completion. Add option for completing
>> requests across CPU nodes via soft IRQ or IPI.
>>
>> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
>
>> +        let text = core::str::from_utf8(page)?.trim();
>> +        let value = text.parse::<u8>().map_err(|_| EINVAL)?;
>
> Same comment about kstrtobool here as on the other patch.

This one does not parse a bool, it parses the `IRQMode` enum. I don't
think we need to use kernel C integer parsing functions here, if that is
what you suggest.


Best regards,
Andreas Hindborg