linux-kernel - Re: [PATCH] accel/rocket: Fix usages of kfree() and sizeof()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DC1UJQKMO63Z.1ZLS5VS0OXZAE@brighamcampbell.com>
Date: Wed, 13 Aug 2025 21:56:31 -0600
From: "Brigham Campbell" <me@...ghamcampbell.com>
To: "Markus Elfring" <Markus.Elfring@....de>,
 <dri-devel@...ts.freedesktop.org>, <lkp@...el.com>
Cc: "LKML" <linux-kernel@...r.kernel.org>, "Julia Lawall"
 <julia.lawall@...ia.fr>, "Oded Gabbay" <ogabbay@...nel.org>, "Tomeu Vizoso"
 <tomeu@...euvizoso.net>, "dri-devel"
 <dri-devel-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH] accel/rocket: Fix usages of kfree() and sizeof()

On Wed Aug 13, 2025 at 11:56 AM MDT, Markus Elfring wrote:
>> Replace usages of kfree() with kvfree() for pointers which were
>> allocated using kvmalloc(), as required by the kernel memory management
>> API.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc1#n145

All issues addressed by this patch were introduced by the following
commit:

Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")

>> Use sizeof() on the type that a pointer references instead of …
>
> Would it be helpful to offer desirable changes by separate update steps?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc1#n81

Tomeu? Oded? Would either of you prefer that I split this patch into two
patches (one to fix kfree()->kvfree() and another to fix sizeof())?

I had considered splitting it into two patches, but the changes were so
minor that I figured it wasn't worth it. Please let me know if you
prefer separate patches and I'll gladly prep another revision.

Thanks,
Brigham