linux-kernel - Re: [PATCH v8 06/32] x86/resctrl: Move L3 initialization into new helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12a40a52-1e9d-4afd-a143-f337b6651f14@intel.com>
Date: Wed, 13 Aug 2025 20:58:05 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v8 06/32] x86/resctrl: Move L3 initialization into new
 helper function

Hi Tony,

On 8/11/25 11:16 AM, Tony Luck wrote:
> +static void domain_add_cpu_mon(int cpu, struct rdt_resource *r)
> +{
> +	int id = get_domain_id_from_scope(cpu, r->mon_scope);
> +	struct list_head *add_pos = NULL;
> +	struct rdt_domain_hdr *hdr;
> +
> +	lockdep_assert_held(&domain_list_lock);
> +
> +	if (id < 0) {
> +		pr_warn_once("Can't find monitor domain id for CPU:%d scope:%d for resource %s\n",
> +			     cpu, r->mon_scope, r->name);
> +		return;
> +	}
> +
> +	hdr = resctrl_find_domain(&r->mon_domains, id, &add_pos);
> +	if (hdr) {
> +		if (!domain_header_is_valid(hdr, RESCTRL_MON_DOMAIN, r->rid))
> +			return;
> +		cpumask_set_cpu(cpu, &hdr->cpu_mask);
> +
> +		return;
> +	}
> +
> +	switch (r->rid) {
> +	case RDT_RESOURCE_L3:
> +		l3_mon_domain_setup(cpu, id, r, add_pos);
> +		break;
> +	default:
> +		WARN_ON_ONCE(1);

As mentioned in v7 feedback [1] this change is inconsistent with similar change
to partner function domain_remove_cpu_mon(). Since you did not respond I expected the
code to be consistent in this version. Specifically, this can be:
		pr_warn_once("Unknown resource rid=%d\n", r->rid);
Reinette

[1] https://lore.kernel.org/lkml/6ac15beb-7306-4507-b88b-b6f6cca66def@intel.com/