linux-kernel - Re: [PATCH] squashfs: Verify inode mode when loading from disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <224b26b2-f06e-497e-a3d3-de56360d1a61@squashfs.org.uk>
Date: Thu, 14 Aug 2025 16:14:09 +0100
From: Phillip Lougher <phillip@...ashfs.org.uk>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
 Andrew Morton <akpm@...ux-foundation.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] squashfs: Verify inode mode when loading from disk

On 13/08/2025 08:17, Tetsuo Handa wrote:
> The inode mode loaded from corrupted disk might by error contain the file
> type bits. Since the file type bits are set by squashfs_read_inode() using
> bitwise OR, the file type bits must not be set by squashfs_new_inode() from
> squashfs_read_inode(); otherwise, an invalid file type bits later confuses
> may_open().
>
> Reported-by: syzbot <syzbot+895c23f6917da440ed0d@...kaller.appspotmail.com>
> Closes: https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Reviewed-by: Phillip Lougher <phillip@...ashfs.org.uk>