linux-kernel - Re: [PATCH] iomap: use largest_zero_folio() in iomap_dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ujw7gc4mg4oi5qpkjqrvvto7qewpqthuid63etsetzag5epyug@zmpq2g2btd5i>
Date: Thu, 14 Aug 2025 23:18:53 +0200
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, mcgrof@...nel.org, gost.dev@...sung.com, 
	linux-xfs@...r.kernel.org, Pankaj Raghav <p.raghav@...sung.com>
Subject: Re: [PATCH] iomap: use largest_zero_folio() in iomap_dio_zero()

On Thu, Aug 14, 2025 at 11:27:13AM -0700, Darrick J. Wong wrote:
> On Thu, Aug 14, 2025 at 04:21:37PM +0200, Pankaj Raghav (Samsung) wrote:
> > From: Pankaj Raghav <p.raghav@...sung.com>
> > 
> > iomap_dio_zero() uses a custom allocated memory of zeroes for padding
> > zeroes. This was a temporary solution until there was a way to request a
> > zero folio that was greater than the PAGE_SIZE.
> > 
> > Use largest_zero_folio() function instead of using the custom allocated
> > memory of zeroes. There is no guarantee from largest_zero_folio()
> > function that it will always return a PMD sized folio. Adapt the code so
> > that it can also work if largest_zero_folio() returns a ZERO_PAGE.
> > 
> > Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
> 
> Seems fine to me, though I wonder if this oughn't go along with the
> rest of the largest_zero_folio changes?

I included them in one of the early versions but later removed as we had
to rework the implementation multiple times. I just wanted to reduce the
scope of the series and send out changes that uses the API separately :).

> 
> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

Thanks!

-- 
Pankaj Raghav