linux-kernel - Re: [PATCH v8 15/32] x86,fs/resctrl: Add an architectural hook called for each mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c587070-5f27-4a7c-9dd0-ff702fc9c6cb@intel.com>
Date: Thu, 14 Aug 2025 14:37:36 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v8 15/32] x86,fs/resctrl: Add an architectural hook called
 for each mount

Hi Tony,

On 8/11/25 11:16 AM, Tony Luck wrote:
> Enumeration of Intel telemetry events is an asyncronnous process involving

"asyncronnous" -> "asynchronous"

> several mutually dependent drivers added as auxiliary devices during
> the device_initcall() phase of Linux boot. The process completes after
> the probe functions for these drivers are called. But this happens after

"for these drivers" -> "of these drivers"?

"are called" -> "completes" or "are run"?
(i.e the probe functions should not just be called but need to finish their
work?)

> resctrl_arch_late_init() is executed.
> 
> Tracing the enumeration process shows that it does complete a full seven
> seconds before the earliest possible mount of the resctrl file system
> (when included in /etc/fstab for automatic mount by systemd).
> 
> Add a hook at the beginning of the mount code that will be used
> to check for telemetry events and initialize if any are found.
> 
> Call the hook on every attempted mount. But expectations are that

"But expectations" -> "Expectations"

> most actions (like enumeration) will only need to be performed
> on the first call.
> 
> The call is made with no locks held. Architecture code is responsible

"The call is made with no locks held." -> "resctrl filesystem calls the
hook with no locks held."
(imperative)

> for any required locking.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Reinette