linux-kernel - Re: [PATCH 2/2] drm/bridge: it66121: Add it66122 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ea5626b-6e01-47d9-985d-16eb6e3b782f@ti.com>
Date: Thu, 14 Aug 2025 09:32:48 +0530
From: devarsh <devarsht@...com>
To: Nishanth Menon <nm@...com>, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, David Airlie
	<airlied@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Laurent Pinchart
	<Laurent.pinchart@...asonboard.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        Robert Nelson <robertcnelson@...il.com>,
        Jason Kridner <jkridner@...gleboard.org>
Subject: Re: [PATCH 2/2] drm/bridge: it66121: Add it66122 support

Hi Nishanth,

Thanks for the patch.

On 14/08/25 00:38, Nishanth Menon wrote:
> The IT66122 is a drop in replacement for the IT66122. 

The IT66122 is a drop in replacement for the IT66121

The part is
> register compatible with what we use of the IT66121. The only relevant
> change being the PID is now 0x0622 vs 0x0612. Add this extra PID so
> probe does not fail during the PID check with these new parts.
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> 
> Note: checkpatch --strict reports:
> CHECK: No space is necessary after a cast
> #45: FILE: drivers/gpu/drm/bridge/ite-it66121.c:1643:
> +	{ "it66122", (kernel_ulong_t) &it66122_chip_info },
> 
> I chose to retain existing style - let me know if we want to clean this
> up as well.
> 
> NOTE: .id = ID_IT66121 is explicitly used as indication of reuse of
> existing it66121 compatibility.
> 
>  drivers/gpu/drm/bridge/ite-it66121.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index aa7b1dcc5d70..329fa47a5701 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1618,6 +1618,12 @@ static const struct it66121_chip_info it66121_chip_info = {
>  	.pid = 0x0612,
>  };
>  
> +static const struct it66121_chip_info it66122_chip_info = {
> +	.id = ID_IT66121,

I think better to create separate .id as done for other chip_info structs :

.id = ID_IT66122

Regards
Devarsh

> +	.vid = 0x4954,
> +	.pid = 0x0622,
> +};
> +
>  static const struct it66121_chip_info it6610_chip_info = {
>  	.id = ID_IT6610,
>  	.vid = 0xca00,
> @@ -1626,6 +1632,7 @@ static const struct it66121_chip_info it6610_chip_info = {
>  
>  static const struct of_device_id it66121_dt_match[] = {
>  	{ .compatible = "ite,it66121", &it66121_chip_info },
> +	{ .compatible = "ite,it66122", &it66122_chip_info },
>  	{ .compatible = "ite,it6610", &it6610_chip_info },
>  	{ }
>  };
> @@ -1633,6 +1640,7 @@ MODULE_DEVICE_TABLE(of, it66121_dt_match);
>  
>  static const struct i2c_device_id it66121_id[] = {
>  	{ "it66121", (kernel_ulong_t) &it66121_chip_info },
> +	{ "it66122", (kernel_ulong_t) &it66122_chip_info },
>  	{ "it6610", (kernel_ulong_t) &it6610_chip_info },
>  	{ }
>  };