linux-kernel - Re: [PATCH v7 09/13] PCI: Add Cix Technology Vendor and Device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814222358.GA352330@bhelgaas>
Date: Thu, 14 Aug 2025 17:23:58 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
	fugang.duan@...tech.com, guoyin.chen@...tech.com,
	peter.chen@...tech.com, cix-kernel-upstream@...tech.com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 09/13] PCI: Add Cix Technology Vendor and Device ID

On Wed, Aug 13, 2025 at 12:23:27PM +0800, hans.zhang@...tech.com wrote:
> From: Hans Zhang <hans.zhang@...tech.com>
> 
> Add Cixtech P1 (internal name sky1) as a vendor and device ID for PCI
> devices. This ID will be used by the CIX Sky1 PCIe host controller driver.
> 
> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
> ---
>  include/linux/pci_ids.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 92ffc4373f6d..24b04d085920 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2631,6 +2631,9 @@
>  
>  #define PCI_VENDOR_ID_CXL		0x1e98
>  
> +#define PCI_VENDOR_ID_CIX		0x1f6c
> +#define PCI_DEVICE_ID_CIX_SKY1		0x0001

I only see these used once in this series, so they probably should be
defined in the file that uses them, per the comment at the top of this
file.

Also, https://pcisig.com/membership/member-companies?combine=0x1f6c
doesn't show 0x1f6c as assigned to CIX.  That database often seems
incomplete, but please double check to make sure the ID is actually
reserved.