linux-kernel - Re: [PATCH v14 4/5] x86/sgx: Implement ENCLS[EUPDATESVN]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5e9a2fc1b3f11ed8bf1525a53d0f7ce830200c5.camel@intel.com>
Date: Thu, 14 Aug 2025 22:31:00 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "Reshetova, Elena" <elena.reshetova@...el.com>, "Hansen, Dave"
	<dave.hansen@...el.com>
CC: "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
	"mingo@...nel.org" <mingo@...nel.org>, "Scarlata, Vincent R"
	<vincent.r.scarlata@...el.com>, "x86@...nel.org" <x86@...nel.org>,
	"jarkko@...nel.org" <jarkko@...nel.org>, "Annapurve, Vishal"
	<vannapurve@...gle.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Mallick, Asit K" <asit.k.mallick@...el.com>,
	"Aktas, Erdem" <erdemaktas@...gle.com>, "Cai, Chong" <chongc@...gle.com>,
	"Bondarevska, Nataliia" <bondarn@...gle.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "Raynor, Scott" <scott.raynor@...el.com>
Subject: Re: [PATCH v14 4/5] x86/sgx: Implement ENCLS[EUPDATESVN]


> > 
> > > 
> > > + * Return:
> > > + * * %0:		- Success or not supported
> > > + * * %-EAGAIN:		- Can be safely retried, failure is due to lack of
> > > + * *			entropy in RNG
> > 
> > Nit: if another version is ever needed, I think it would be better to make
> > the text vertical aligned w/o the leading '-', i.e.,
> > 
> > 	* %-EAGAIN:	- Can be ....
> > 			  entropy in RNG.
> > 
> > .. instead of
> > 
> > 	* %-EAGAIN:	- Can be ....
> > 			entropy in RNG.
> 
> OK, yes, this can be fixed, indeed. 
> 

I downloaded those patches and checked locally.  I found there's an
unnecessary 'tab' between the error codes and the descriptions, making the
whitespace between them unnecessarily too long.

Please see below diff I came up with:

diff --git a/arch/x86/kernel/cpu/sgx/main.c
b/arch/x86/kernel/cpu/sgx/main.c
index cff5c4d22ac2..c6467628da04 100644
--- a/arch/x86/kernel/cpu/sgx/main.c
+++ b/arch/x86/kernel/cpu/sgx/main.c
@@ -929,10 +929,10 @@ static int sgx_usage_count;
  * cryptographic assets.
  *
  * Return:
- * * %0:               - Success or not supported
- * * %-EAGAIN:         - Can be safely retried, failure is due to lack of
- * *                   entropy in RNG
- * * %-EIO:            - Unexpected error, retries are not advisable
+ * * %0:       - Success or not supported
+ * * %-EAGAIN: - Can be safely retried, failure is due to lack of
+ * *             entropy in RNG
+ * * %-EIO:    - Unexpected error, retries are not advisable
  */
 static int sgx_update_svn(void)
 {